Provide profile, hotreload buttons for non-flutter debugging #3715

Activity

1. bsutton

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Dec 7, 2021
2. DanTup

   added this to the v3.30.0 milestone on Dec 8, 2021
3. DanTup

   added

   in dartRelates to running Dart programsRelates to running Dart programs

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   on Dec 8, 2021
4. DanTup commented on Dec 9, 2021

   

   DanTup

   on Dec 9, 2021

   Member

   More actions

   

   For Flutter we don't actually have a button to jump to the CPU Profiler, it goes to the Performance page. However I've used the same icon for CPU Profiler (since the Performance page is Flutter-specific) for non-Flutter sessions because I don't want to clutter the toolbar too much (eg. adding CPU Profile also for Flutter) or have to find different icons for "CPU Profiler" vs "Performance".
5. DanTup

   added a commit that references this issue on Dec 9, 2021

   Enable Hot Reload on debug toolbar/touchbar for non-Flutter apps

   ...

   ea00f6c
6. DanTup

   closed this as completedin 8bf6261on Dec 9, 2021
7. bsutton commented on Dec 9, 2021

   

   bsutton

   on Dec 9, 2021

   Author

   More actions

   for non-Flutter sessions because I don't want to clutter the toolbar too much

   The icon and target page are find. I was actually referring to memory profiling but I'm happy to have it go to the cpu profile page.

   👍React with 👍1Reacted by Danny Tuppeny
8. DanTup commented on Dec 13, 2021

   

   DanTup

   on Dec 13, 2021

   Member

   More actions

   There was a pre-release build today if you want to switch to try out these new features/fixes in advance of a stable release:

   
9. bsutton commented on Dec 14, 2021

   

   bsutton

   on Dec 14, 2021

   Author

   More actions

   Dan thanks for the work.

   A couple of issues.

   1. I was expecting to see the profiler launch in a separate window.
      I run a two screen system and would normally move the profiler to a different screen so I can see my full dev environment.
      Having the screen embedded in vscode precludes this.

   2. the launcher only opens the cpu profile window.
      I was expecting to see the full suite of devtool windows (e.g. the memory profiler).
10. bsutton commented on Dec 14, 2021

    

    bsutton

    on Dec 14, 2021

    Author

    More actions

    Scenario:
    run a debug session, stop it and then run a second debug session

    Click the dev tool button.
    The tool shows a menu showing the current and last (stopped) session.
    Is this intentional?

    If it is then I think the order is incorrect. It shows the older session first which is also highlighted in blue.
    If we are going to have both then it should have the current session highlighted and it should probably be the first one in the list.
11. DanTup commented on Dec 14, 2021

    

    DanTup

    on Dec 14, 2021

    Member

    More actions

    I was expecting to see the profiler launch in a separate window.

    This is controlled by the dart.embedDevTools setting. It defaults to embedded, but if you set it to false it'll open the full DevTools (with nav so you can move around) in the browser.

    The tool shows a menu showing the current and last (stopped) session.
    Is this intentional?

    Nope, that sounds like a bug that the previous session stopping wasn't handled correctly - I'll take a look. Thanks!
12. DanTup commented on Dec 14, 2021

    

    DanTup

    on Dec 14, 2021

    Member

    More actions

    Nope, that sounds like a bug that the previous session stopping wasn't handled correctly - I'll take a look. Thanks!

    I don't seem to be able to repro this. If you still can, could you file a new issue with more details about exactly what you're running, etc. - and whether you see "Exited" in the Debug Console for the first session before this occurs?

    Capturing logs (with Dart: Capture Logs and leaving everything except Analysis Server ticked) across both sessions may be useful too. Thanks!