Repository navigation
Convert Getter to Method doesn't work for extensions #3846
Description
Describe the bug
Using the refactor feature to convert a getter to a method doesn't work if said getter is part of an extension.
To Reproduce
Steps to reproduce the behavior:
- Add a getter to an extension
- Right click getter name -> Refactor -> Convert Getter to Method
Expected behavior
Getter should be changed to a method.
Example:
enum Category {
metal,
wood,
glass,
}
extension ExtraEnumFuntionality on Category {
String get someValue => 'returnValue'; // FAIL
}
class SomeClass {
String get aValue => 'aReturnValue'; // SUCCESS
}
extension ExtraClassFunctionality on SomeClass {
String get someValue => 'returnValue'; // FAIL
}Versions (please complete the following information):
- VS Code version: 1.64.2
- Dart extension version: 3.34.0
- Dart/Flutter SDK version: Flutter 2.11.0-0.1.pre, Dart 2.17.0
Activity
DanTup commentedon Feb 28, 2022
Thanks! I have a fix for review at https://dart-review.googlesource.com/c/sdk/+/234600/. The change is in the Dart SDK so would ship with an upcoming Dart/Flutter SDK rather than a Dart-Code release. I'll keep this issue open until the change has passed review and landed.
Thanks!
[analysis_server] Handle extensions in convert_getter_to_method
DanTup commentedon Feb 28, 2022
The fix has landed in dart-lang/sdk@0359628.
Merrit commentedon Feb 28, 2022
Well that was quick! Thank you :)