Holding ctrl when hovering paths in text_button.dart returns a range far larger than expected #3867

Activity

1. DanTup

   added

   is bug

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Mar 9, 2022
2. DanTup commented on Mar 9, 2022

   

   DanTup

   on Mar 9, 2022

   MemberAuthor

   More actions

   Seems to be coming from the server like this:

   "originSelectionRange": {
   	"start": {
   		"line": 56,
   		"character": 19
   	},
   	"end": {
   		"line": 124,
   		"character": 26
   	}
   },
   

   Full request/response:

   ==> {
   	"jsonrpc": "2.0",
   	"id": 96,
   	"method": "textDocument/definition",
   	"params": {
   		"textDocument": {
   			"uri": "file:///Users/danny/Dev/Google/flutter/packages/flutter/lib/src/material/text_button.dart"
   		},
   		"position": {
   			"line": 56,
   			"character": 37
   		}
   	}
   }
   <== {
   	"id": 96,
   	"jsonrpc": "2.0",
   	"result": [
   		{
   			"originSelectionRange": {
   				"start": {
   					"line": 56,
   					"character": 19
   				},
   				"end": {
   					"line": 124,
   					"character": 26
   				}
   			},
   			"targetUri": "file:///Users/danny/Dev/Google/flutter/examples/api/lib/material/text_button/text_button.0.dart",
   			"targetRange": {
   				"start": {
   					"line": 0,
   					"character": 0
   				},
   				"end": {
   					"line": 0,
   					"character": 0
   				}
   			},
   			"targetSelectionRange": {
   				"start": {
   					"line": 0,
   					"character": 0
   				},
   				"end": {
   					"line": 0,
   					"character": 0
   				}
   			}
   		}
   	]
   }
   
3. DanTup

   added

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Mar 9, 2022
4. DanTup

   added this to the v3.38.0 milestone on Mar 9, 2022
5. copybara-service

   added a commit that references this issue on Mar 9, 2022

   [analysis_server] Fix end locations of navigation regions for code sa…

   ...

   da5670c
6. DanTup commented on Mar 9, 2022

   

   DanTup

   on Mar 9, 2022

   MemberAuthor

   More actions

   Fixed by dart-lang/sdk@da5670c.
7. DanTup

   closed this as completedon Mar 9, 2022