Use super parameters in snippets #3899

Activity

1. guidezpl

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Apr 1, 2022
2. DanTup commented on Apr 1, 2022

   

   DanTup

   on Apr 1, 2022

   Member

   More actions

   @bwilkerson for code generated by the server (for ex. snippets), should super parameters be used whenever supported, or only if the lint is also enabled?
3. DanTup

   added this to the v3.39.0 milestone on Apr 1, 2022
4. DanTup

   added

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Apr 1, 2022
5. bwilkerson commented on Apr 1, 2022

   

   bwilkerson

   on Apr 1, 2022

   More actions

   I think it's reasonable for snippets to make use of any valid language feature that makes the generated code better.

   I think that it's reasonable to not produce some style of code when there's a lint that prohibits it (that is, to allow lints to reduce the set of valid language features), but I don't think we want to require users to "enable" new language features before we start producing them in generated code. Or, at least, we don't want to require them to enable it again; they already had to opt in once by increasing the minimum SDK version.
6. goderbauer commented on Apr 1, 2022

   

   goderbauer

   on Apr 1, 2022

   More actions

   +1 I think if the package has a lower SDK bound of at least 2.17.0-0 (indicating that super params are supported) the macros should use them.

   👍React with 👍1Reacted by Michael Thomsen
7. DanTup commented on Apr 5, 2022

   

   DanTup

   on Apr 5, 2022

   Member

   More actions

   Working on a change at https://dart-review.googlesource.com/c/sdk/+/240281/.

   It will only work for server-provided snippets, which are currently something you can turn on if on Flutter master using the dart.enableServerSnippets setting but will automatically be enabled when your SDK supports them in an upcoming release of the VS Code extension.

   🚀React with 🚀2Reacted by Michael Goderbauer and Kristen McWilliam
8. copybara-service

   added a commit that references this issue on Apr 6, 2022

   [analysis_server] Use super parameters in Flutter widget snippets

   ...

   fa024be
9. DanTup commented on Apr 6, 2022

   

   DanTup

   on Apr 6, 2022

   Member

   More actions

   Landed in dart-lang/sdk@fa024be.
10. DanTup

    closed this as completedon Apr 6, 2022
11. eseidelGoogle commented on May 2, 2022

    

    eseidelGoogle

    on May 2, 2022

    More actions

    Re: snippets, do https://github.com/Dart-Code/Dart-Code/blob/master/snippets/flutter.json also need to change?
12. DanTup commented on May 2, 2022

    

    DanTup

    on May 2, 2022

    Member

    More actions

    @eseidelGoogle those snippets shipped in the extension cannot adopt to language versions, so updating them will result in errors for anyone on the current stable SDKs (which don't support super params). Those snippets are being phased out - newer Dart/Flutter SDKs (not the current stable version, but future versions) will get their snippets from the server, which can adopt to language versions (and lints).

    We'll automatically switch to the server snippets when they're available (any version of Dart >= 2.17.0-258), so if you're using master you should already see super params in the snippets. If you're on stable, it'll happen automatically after the next stable release.

    Those local snippets will likely be removed some time in the future when we drop support for old SDK versions (there's no planned timeline, but ultimately we'll require versions of the SDK that support LSP and DAP, and you'll need to use an older VS Code extension version if you really need to stick on a very old Dart/Flutter version), but in the meantime they will be left as-is (to be as compatible as possible).

    (lmk if anything isn't clear!)
13. eseidelGoogle commented on May 2, 2022

    

    eseidelGoogle

    on May 2, 2022 via email

    More actions

    Makes sense. Thanks!

    …

    On Mon, May 2, 2022 at 10:50 AM Danny Tuppeny ***@***.***> wrote: @eseidelGoogle <https://github.com/eseidelGoogle> those snippets shipped in the extension cannot adopt to language versions, so updating them will result in errors for anyone on the current stable SDKs (which don't support super params). Those snippets are being phased out - newer Dart/Flutter SDKs (not the current stable version, but future versions) will get their snippets from the server, which can adopt to language versions (and lints). We'll automatically switch to the server snippets when they're available (any version of Dart >= 2.17.0-258 <https://github.com/Dart-Code/Dart-Code/blob/master/src/shared/capabilities/dart.ts#L36>), so if you're using master you should already see super params in the snippets. If you're on stable, it'll happen automatically after the next stable release. Those local snippets will likely be removed some time in the future when we drop support for old SDK versions (there's no planned timeline, but ultimately we'll require versions of the SDK that support LSP and DAP, and you'll need to use an older VS Code extension version if you really need to stick on a very old Dart/Flutter version), but in the meantime they will be left as-is (to be as compatible as possible). (lmk if anything isn't clear!) — Reply to this email directly, view it on GitHub <#3899 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O7C2GKEV7C6FREWO2DJLVIAIVLANCNFSM5SHZM2UQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>