Refactoring (Wrap with...) remove escaping backslash in strings #4002

Activity

1. nicolasmol

   added

   is bug

   on Jun 1, 2022
2. DanTup

   added this to the v3.44.0 milestone on Jun 1, 2022
3. DanTup

   added

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Jun 1, 2022
4. DanTup commented on Jun 1, 2022

   

   DanTup

   on Jun 1, 2022

   Member

   More actions

   @nicolasmol are you able to share a complete code sample that triggers this? I don't seem to be able to repro with a simple case:

   

   Can you also confirm what version of VS Code, the Dart extension, and the Flutter SDK you're using? Thanks!
5. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Jun 1, 2022
6. nicolasmol commented on Jun 1, 2022

   

   nicolasmol

   on Jun 1, 2022

   Last edited by nicolasmol

   Author

   More actions

   Flutter 3.0.1 • channel stable • https://github.com/flutter/flutter.git
   Framework • revision fb57da5f94 (il y a 13 jours) • 2022-05-19 15:50:29 -0700
   Engine • revision caaafc5604
   Tools • Dart 2.17.1 • DevTools 2.12.2

   environment:
     sdk: ">=2.2.2 <3.0.0"
   

   Text(
       "\$34",
       style: TextStyle(
         color: _purple,
         fontWeight: FontWeight.bold,
         fontSize: 17.0,
       ),
     )
7. DanTup commented on Jun 1, 2022

   

   DanTup

   on Jun 1, 2022

   Member

   More actions

   Thanks! Turns out it only occurs with numbers after the $ and not text. I'll take a look.
8. DanTup

   removed

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Jun 1, 2022
9. DanTup commented on Jun 1, 2022

   

   DanTup

   on Jun 1, 2022

   Member

   More actions

   This is related to us not detecting snippets reliably. We definitely need to find a proper way to do this:

   Dart-Code/src/extension/analysis/analyzer_lsp_snippet_text_edits.ts

   Lines 46 to 48 in 5b4d2e2

   	// HACK: This should be checking InsertTextFormat:
   	// https://github.com/microsoft/language-server-protocol/issues/724#issuecomment-800334721
   	const hasSnippet = /\$(\d+|\{\d+(?:[:|][^}]*)?\})/.test(textEdit.newText);
10. DanTup

    closed this as completedin 94bd55don Jun 20, 2022
11. DanTup commented on Jun 21, 2022

    

    DanTup

    on Jun 21, 2022

    Member

    More actions

    If you want to verify the fix before it ships, you can switch to the pre-release versions of the Dart+Flutter extension in VS Code shown here:

    

    The versions with the fix are v3.43.20220621 (and the stable version they'll ship in is v3.44).

    Please let me know if you hit any issues. Thanks!
12. keertip

    added a commit that references this issue on Sep 2, 2025

    Improve detection of Snippets in code actions from server

    ...

    This issue will close once commit 94bd55d is merged into the 'master' branch.

    94bd55d