Extract Method shows up on import prefix #4029

Activity

1. DanTup

   added

   is bug

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Jun 23, 2022
2. DanTup

   added this to the v3.44.0 milestone on Jun 23, 2022
3. DanTup commented on Jun 23, 2022

   

   DanTup

   on Jun 23, 2022

   MemberAuthor

   More actions

   Same occurs without the prefix if it's nullable:

   import 'dart:io';
   
   File? a;

   It also fails if invoked:

   [Error - 11:20:19 AM] An error occurred while handling workspace/executeCommand request: Bad state: No type: File
   #0      ExpressionExtension.typeOrThrow (package:analyzer/src/dart/ast/extensions.dart:121:7)
   #1      ExtractMethodRefactoringImpl._initializeParameters (package:analysis_server/src/services/refactoring/extract_method.dart:724:41)
   #2      ExtractMethodRefactoringImpl.checkInitialConditions (package:analysis_server/src/services/refactoring/extract_method.dart:199:24)
   #3      AbstractRefactorCommandHandler.getRefactoring (package:analysis_server/src/lsp/handlers/commands/abstract_refactor.dart:56:26)
   #4      ValidateRefactorCommandHandler.execute.<anonymous closure> (package:analysis_server/src/lsp/handlers/commands/validate_refactor.dart:42:33)
   
4. copybara-service

   added a commit that references this issue on Jun 23, 2022

   [analysis_server] Disallow Extract Method on nullable type names and …

   ...

   23f1c54
5. DanTup commented on Jun 23, 2022

   

   DanTup

   on Jun 23, 2022

   MemberAuthor

   More actions

   Fixed by dart-lang/sdk@23f1c54.
6. DanTup

   closed this as completedon Jun 23, 2022