Repository navigation
Wrapping a widget moves the cursor to the closing bracket #4061
Description
Describe the bug
Wrapping a widget moves the cursor to the closing bracket.
To Reproduce
wrap_widget.mp4
Expected behavior
Wrapping a widget should move the cursor to the opening bracket.
Please complete the following information:
- Operating System and version: Windows 10 and macOS Big Sur
- VS Code version: 1.69.1
- Dart extension version: 3.44.0
- Dart/Flutter SDK version: 3.0.3
Activity
DanTup commentedon Jul 18, 2022
@bwilkerson this sounds reasonable to me and would be a fairly simple fix. Although the cursor defaulting to the end of the string may be LSP-specific (there is an implicit final tabstop at the end of any snippet if there isn't an explicit one) so I don't know how adding a selection offset to the edit may affect other clients. Any thoughts?
The change I would propose is something like this:
bwilkerson commentedon Jul 18, 2022
The same assist in IntelliJ currently leaves the cursor at the same offset as before the edit was applied, so adding a reasonable selection point seems like a win there as well.
[analysis_server] Set selection/selectionLength for Flutter "Wrap wit…