Hovering over constructor's parameters shows an oversized font for the type #4120

Activity

1. osaxma

   added

   is bug

   on Aug 25, 2022
2. osaxma

   changed the title [-]Hovering over parameters shows an oversized font for the type[/-] [+]Hovering over constructor's parameters shows an oversized font for the type[/+] on Aug 25, 2022
3. DanTup commented on Aug 25, 2022

   

   DanTup

   on Aug 25, 2022

   Last edited by DanTup

   Member

   More actions

   Thanks, I can repro.

   class A {
     /// aaa
     final String aaa; // hover over aaa
   
     A({required this.aaa}); // hover over aaa
   }

   There's no obvious difference in the response from the server:

   {"id":653,"jsonrpc":"2.0","result":{"contents":{"kind":"markdown","value":"```dart\nString aaa\n```\nType: `String`\n*package:dartcode_flutter_4118/main.dart*\n\n---\naaa"},"range":{"end":{"character":18,"line":4},"start":{"character":15,"line":4}}}}
   {"id":654,"jsonrpc":"2.0","result":{"contents":{"kind":"markdown","value":"```dart\n{required String aaa}\n```\nType: `String`\n---\naaa"},"range":{"end":{"character":22,"line":6},"start":{"character":19,"line":6}}}}
   

   There's a missing newline before the package in the first one though:

   

   I think either LSP client or VS Code are supposed to convert --- to a full with line, but I can't see that on the second one, so perhaps that's related (microsoft/vscode#65094?).

   👍React with 👍1Reacted by osama
4. DanTup commented on Aug 25, 2022

   

   DanTup

   on Aug 25, 2022

   Last edited by DanTup

   Member

   More actions

   So I think there are two issues here:

   1. We need two newlines before --- for it to be rendered as a horizontal line. Otherwise it's being interpreted to mean the line before is a header. This needs fixing in the server.
   2. The missing newline before package: in the rendering may be a VS Code issue - it's rendering differently to I would expect (or GitHub does) so I've filed Newline missing in markdown rendering microsoft/vscode#159161.

   Edit: This was just one issue, which was a missing \n after Type: because a single newline in Markdown is essentially ignored and the two lines still treated as a single paragraph.
5. DanTup

   added this to the v3.50.0 milestone on Aug 25, 2022
6. DanTup

   added

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Aug 25, 2022
7. DanTup commented on Sep 5, 2022

   

   DanTup

   on Sep 5, 2022

   Member

   More actions

   Fix on the way at https://dart-review.googlesource.com/c/sdk/+/257582/.
8. copybara-service

   added a commit that references this issue on Sep 6, 2022

   [analysis_server] Fix missing newlines after types in LSP hovers

   ...

   8bf496e
9. DanTup commented on Sep 6, 2022

   

   DanTup

   on Sep 6, 2022

   Member

   More actions

   Fixed by dart-lang/sdk@8bf496e. It's an SDK change, so will show up in a future SDK release.

   🎉React with 🎉1Reacted by osama
10. DanTup

    closed this as completedon Sep 6, 2022
11. DanTup

    added

    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    on Sep 6, 2022