Skip to content

Change Container() to Placeholder() in snippets #4136

Closed
Closed
Change Container() to Placeholder() in snippets#4136
Labels
in flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.54.0

Description

@DanTup
DanTup
opened on Sep 1, 2022

See discussion at #3975 (comment). Empty Container()s may trigger lints, and Placeholder seems like a perfect replacement (const Placeholder()).

Needs doing in both the local snippets and the server.

Activity

  1. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in flutterRelates to running Flutter apps
    on Sep 1, 2022
  2. DanTup
    added this to the v3.50.0 milestone on Sep 1, 2022
  3. DanTup
    modified the milestones: v3.50.0, v3.52.0 on Oct 3, 2022
  4. DanTup
    modified the milestones: v3.52.0, v3.54.0 on Oct 31, 2022
  5. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Nov 7, 2022

  6. DanTup commented on Nov 7, 2022

    @DanTup
    DanTup
    on Nov 7, 2022
    MemberAuthor

    Server work in https://dart-review.googlesource.com/c/sdk/+/268320.

  7. DanTup
    closed this as completedin 02953b3on Nov 7, 2022
  8. copybara-service
    added a commit that references this issue on Nov 7, 2022

    [analysis_server] Change Flutter snippets to use Placeholder

    5437073
  9. keertip
    added a commit that references this issue on Sep 2, 2025

    Switch Containers for Placeholders in legacy snippets

    02953b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions