Quick fixes are ordered badly #4203

Activity

1. DanTup

   added

   is bug

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Oct 6, 2022
2. DanTup

   added this to the v3.52.0 milestone on Oct 6, 2022
3. DanTup commented on Oct 31, 2022

   

   DanTup

   on Oct 31, 2022

   MemberAuthor

   More actions

   🤔

   

   Using a recent bleeding-edge build.
4. DanTup commented on Oct 31, 2022

   

   DanTup

   on Oct 31, 2022

   MemberAuthor

   More actions

   

   2.18.0
5. DanTup commented on Oct 31, 2022

   

   DanTup

   on Oct 31, 2022

   MemberAuthor

   More actions

   Seems to depend on the specific text.. changing var back to Uint8List triggers it:

   

   This seems to be match the order from the server:

   {
   	"id": 134,
   	"jsonrpc": "2.0",
   	"result": [
   		{
   			"kind": "source.sortMembers",
   			"title": "Sort Members"
   		},
   		{
   			"kind": "source.organizeImports",
   			"title": "Organize Imports"
   		},
   		{
   			"kind": "source.fixAll",
   			"title": "Fix All"
   		},
   		{
   			"kind": "refactor.extract",
   			"title": "Extract Method"
   		},
   		{
   			"kind": "refactor.extract",
   			"title": "Extract Local Variable"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.create.localVariable",
   			"title": "Create local variable 'Uint8List'"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.remove.unusedLocalVariable",
   			"title": "Remove unused local variable"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.ignore.line",
   			"title": "Ignore 'prefer_final_locals' for this line"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.ignore.line",
   			"title": "Ignore 'unused_local_variable' for this line"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.ignore.file",
   			"title": "Ignore 'prefer_final_locals' for this file"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.ignore.file",
   			"title": "Ignore 'unused_local_variable' for this file"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.create.class",
   			"title": "Create class 'Uint8List'"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.create.mixin",
   			"title": "Create mixin 'Uint8List'"
   		},
   		{
   			"diagnostics": [],
   			"edit": {},
   			"kind": "quickfix.import.librarySdk",
   			"title": "Import library 'dart:typed_data'"
   		}
   	]
   }
6. DanTup commented on Oct 31, 2022

   

   DanTup

   on Oct 31, 2022

   MemberAuthor

   More actions

   The cause of this was that we de-dupe when there are overlapping fixes on the same line. The de-duping code created a new "combined" CodeAction which was not storing its priority properly, and always being sorted last.

   Fix at https://dart-review.googlesource.com/c/sdk/+/266680.
7. DanTup

   modified the milestones: v3.52.0, v3.54.0 on Oct 31, 2022
8. copybara-service

   added a commit that references this issue on Oct 31, 2022

   [analysis_server] Ensure code action fix priorities are respected eve…

   ...

   00ca14f
9. DanTup commented on Oct 31, 2022

   

   DanTup

   on Oct 31, 2022

   MemberAuthor

   More actions

   Fixed by dart-lang/sdk@00ca14f.
10. DanTup

    closed this as completedon Oct 31, 2022
11. DanTup

    modified the milestones: v3.54.0, v3.52.0 on Oct 31, 2022
12. DanTup

    added

    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    on Oct 31, 2022