Skip to content

Use line/col information from source locations instead of mapping tokenPosTables #4209

Closed

Description

@DanTup

While investigating #4208 I noticed that the responses from the VM have line/col information and we don't need to look it up from tokenPosTable (as of dart-lang/sdk@2db8f37). Assuming the data is there, this may save us fetching a lot of scripts.

(We should check both old and new DAPs).

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Oct 7, 2022
  2. added this to the v3.52.0 milestone on Oct 7, 2022
  3. DanTup commented on Oct 10, 2022

    @DanTup
    MemberAuthor

    Fixed by cf21e01 in legacy DAP and dart-lang/sdk@946eec8 for new SDK DAPs.

    @maks I haven't specifically tested your issue yet, but if you're on the pre-release versions of the Dart extension (see below) then this might be #4208 might be resolved for you (since we shouldn't need to fetch the scripts - the thing that was failing - in most cases anymore).

    Dart/Flutter pre-release versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions