Skip to content

Improve rendering of Uint8List (and friends) in the debugger #4213

Closed
Closed
Improve rendering of Uint8List (and friends) in the debugger#4213
Labels
in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.58.0

Description

@DanTup
DanTup
opened on Oct 11, 2022
final a = [1, 2, 3, 4, 5, 6];
final b = Uint8List.fromList(a);
final c = Uint16List.fromList(a)

List a looks like a list, but the others do not:

Screenshot 2022-10-11 at 14 36 05

In the VM Service traffic, we can see the item has a length: 6 so we might be able to present it the same as a standard List:

Screenshot 2022-10-11 at 14 39 53

Activity

  1. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Oct 11, 2022
  2. DanTup
    added this to the v3.52.0 milestone on Oct 11, 2022

  3. DanTup commented on Oct 11, 2022

    @DanTup
    DanTup
    on Oct 11, 2022
    MemberAuthor

    Fixed with https://dart-review.googlesource.com/c/sdk/+/263620 in the new DAPs.

    Screenshot 2022-10-11 at 17 15 48

    Since this change is in the SDK, it'll show up in an SDK update.

  4. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Oct 11, 2022
  5. copybara-service
    added a commit that references this issue on Oct 17, 2022

    [dds/dap] Improve handling of lists in variables requests

    ae352fe

  6. DanTup commented on Oct 18, 2022

    @DanTup
    DanTup
    on Oct 18, 2022
    MemberAuthor

    Fixed by dart-lang/sdk@ae352fe. This will ship in an upcoming SDK release and applies to the new debug adapters (which will roll out progressively, but can be opted-in with "dart.previewSdkDaps": true in VS Code settings).

  7. DanTup
    closed this as completedon Oct 18, 2022
  8. DanTup
    modified the milestones: v3.52.0, Next SDK Release on Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions