Skip to content

Nested Code folding not working correctly #4242

Closed
Closed
Nested Code folding not working correctly#4242
Labels
in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.54.0

Description

@DanTup
DanTup
opened on Nov 3, 2022

Noted by @methompson in #4121 (comment)

class MyClass {
  //
  method1(String a) {
    //
  }
  //
}
{
	"id": 202,
	"jsonrpc": "2.0",
	"result": [
		{
			"endLine": 1,
			"startLine": 0
		},
		{
			"endLine": 4,
			"startLine": 2
		}
	]
}

Here, the folding for the class goes from line 0-1 and doesn't actually cover the class at all. If you remove the first comment, it results in the folding for class not appearing at all.

Activity

  1. DanTup
    added
    is bug
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    on Nov 3, 2022
  2. DanTup
    added this to the v3.54.0 milestone on Nov 3, 2022
  3. DanTup
    changed the title [-]Code folding not working correctly for classes[/-] [+]Nested Code folding not working correctly[/+] on Nov 3, 2022
  4. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Nov 3, 2022

  5. DanTup commented on Nov 3, 2022

    @DanTup
    DanTup
    on Nov 3, 2022
    MemberAuthor

    https://dart-review.googlesource.com/c/sdk/+/267620

  6. copybara-service
    added a commit that references this issue on Nov 3, 2022

    [analysis_server] Fix folding for nested blocks in line-folding-only …

    e417e3c

  7. DanTup commented on Nov 3, 2022

    @DanTup
    DanTup
    on Nov 3, 2022
    MemberAuthor

    Fixed by dart-lang/sdk@e417e3c, ships in the SDK.

  8. DanTup
    closed this as completedon Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions