"Unresponsive extension host" opening large project #4326

Activity

1. DanTup

   added

   is performance

   on Dec 28, 2022
2. DanTup

   added this to the v3.58.0 milestone on Dec 28, 2022
3. DanTup commented on Jan 3, 2023

   

   DanTup

   on Jan 3, 2023

   Last edited by DanTup

   MemberAuthor

   More actions

   

   rebuildFromOutline walks down the tree and calls some expensive code. The total in this profile was 3.5s.
4. DanTup commented on Jan 3, 2023

   

   DanTup

   on Jan 3, 2023

   MemberAuthor

   More actions

   Whenever we discover a test, we do this:

   Dart-Code/src/shared/test/test_model.ts

   Lines 439 to 440 in 686c268

   	this.updateNode(testNode.parent);
   	this.rebuildSuiteNode(suite);

   This rebuilds the parent, which means for a group with lots of tests, we're rebuilding all the siblings. But we then rebuild the entire suite, which not only duplicates all of that work, but then also does it for the rest of the file.

   The intention here is to ensure the parent statuses are up-to-date, but seems like maybe we could a) avoid the duplicated work, b) walk up instead of down to avoid doing more nodes then we need to, c) do we even need to update any status here? Can a newly-discovered test even change any parent statuses since it has the lowest status?

   (it's possible we need to rebuild the parent in order to replace its children, but we should find a way to do that that doesn't involve calling createTestItem for every sibling again).
5. DanTup

   added a commit that references this issue on Jan 3, 2023

   Avoid rebuilding more of test tree/model than necessary

   ...

   56b7dd1
6. DanTup

   closed this as completedin #4328on Jan 4, 2023
7. DanTup

   added a commit that references this issue on Jan 4, 2023

   Avoid rebuilding more of test tree/model than necessary

   ...

   52a6e18