Skip to content

Selecting type name does not highlight references #4376

Closed
Closed
Selecting type name does not highlight references#4376
Labels
in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.60.0

Description

@blaugold
blaugold
opened on Feb 4, 2023

Describe the bug

Selecting a type name does not highlight references to the type in the current file.

To Reproduce

See video.

Expected behavior

I feel like selecting a type name did at some point cause references to be highlighted like it is the case for constructors in the included video, but I'm not sure anymore :)

Screenshots

Screen.Recording.2023-02-05.at.00.07.09.mov

Please complete the following information:

  • Operating System and version: macOS 13.1 (22C65)
  • VS Code version: 1.75.0
  • Dart extension version: 3.58.0
  • Dart/Flutter SDK version: Flutter 3.7.1 Dart 2.19.1
  • Target device (if the issue relates to Flutter debugging):

Activity

  1. blaugold
    added
    is bug
    on Feb 4, 2023
  2. DanTup
    added this to the v3.60.0 milestone on Feb 6, 2023
  3. DanTup
    added
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Feb 6, 2023
  4. copybara-service
    added a commit that references this issue on Feb 6, 2023

    [analysis_server] Include Class/Enum/Mixin declaration names in occur…

    5b09a3d

  5. DanTup commented on Feb 6, 2023

    @DanTup
    DanTup
    on Feb 6, 2023
    Member

    Fixed by https://dart-review.googlesource.com/c/sdk/+/281182.

    This change is in the Dart analysis server so will ship with a future Dart/Flutter SDK release rather than show up in the VS Code extension release.

  6. DanTup
    closed this as completedon Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions