Repository navigation
Test status indicator is duplicated #4384
Description
Describe the bug
Noticed that the test status indicator (play button or spinner) got duplicated for the whole line length of the test.
To Reproduce
No steps. This is a new test file and I noticed that it's too much of the visual noise.
Expected behavior
Only one indicator.
Screenshots
Screen.Recording.2023-02-13.at.16.48.25.mov
Please complete the following information:
- Operating System and version: macOS 12.6
- VS Code version: 1.75.1
- Dart extension version: 3.58
- Dart/Flutter SDK version: Dart SDK version: 2.19.0 (stable) (Mon Jan 23 11:29:09 2023 -0800) on "macos_x64"
- Target device (if the issue relates to Flutter debugging): -
Activity
DanTup commentedon Feb 14, 2023
I'm not able to reproduce this. Can you reproduce in a new file? Are there any specific steps?
incendial commentedon Feb 15, 2023
Unfortunately, no, I don't have any steps either. Feel free to close this one if without the steps it's useless. If I see this again I'll get back.
DanTup commentedon Feb 15, 2023
If you see it again, could you also get a screenshot of what the Test Explorer tree looks like for this file?
I'll leave this open for now with the awaiting-info tag. If you see it again post back, and otherwise the bot will close it in ~30 days. Thanks!
github-actions commentedon Mar 8, 2023
This issue has been marked stale because it is tagged awaiting-info for 20 days with no activity. Remove the stale label or comment to prevent the issue being closed in 10 days.
incendial commentedon Mar 12, 2023
Got this problem again
incendial commentedon Mar 12, 2023
Test explorer:
incendial commentedon Mar 12, 2023
I was able to repro it in one go, but then it stopped appearing 😞
Investigating...
incendial commentedon Mar 12, 2023
As you can see, I'm waiting for the icon to appear before writing the body.
repro.mov
DanTup commentedon Mar 13, 2023
@incendial I can repro with those steps, thank you!
1 remaining item
DanTup commentedon Mar 13, 2023
I think at least part of this is a VS Code bug, I've filed microsoft/vscode#176951. I'm still trying to figure out if there's more to it though (and if there is, whether it's an issue here or there).
DanTup commentedon Mar 13, 2023
I think this might be entirely a VS Code issue. I was able to adapt their sample to have the full issue (not just duplicated icons, but them not disappearing on the next update - which is what we're seeing here). I've added some notes to microsoft/vscode#176951 (comment).
Hopefully once that issue is fixed there, it'll be good here. I'll keep this issue open to track it until it's resolved though.
incendial commentedon Mar 13, 2023
Interesting that no one else had spotted it 😅. Thank you!
Interesting that I had never had it with TS, for example 🤔.
DanTup commentedon Mar 13, 2023
I think it depends on some specifics:
<enter>inside itSo for example the sample test provider they had always truncated the test at the end of the first line, so although the issue showed up briefly when you pressed
<enter>, the update "fixed" it by replacing the test range which triggers VS Code replacing the duplicated icons.(there's a lot of assumptions there though, we'll see what they say when it's looked at :-))
DanTup commentedon Jun 13, 2023
This was fixed in the latest VS Code.