Skip to content

Inlay hints with inner generics #4406

Closed
Closed
Inlay hints with inner generics#4406
Labels
in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.60.0

Description

@Zekfad
Zekfad
opened on Feb 24, 2023

Is your feature request related to a problem? Please describe.
Currently Inlay hints can show generics and their inferred types, but inner types are not clickable.

Describe the solution you'd like
Make inner generics interactive.

Describe alternatives you've considered
-

Additional context

Current behavior

image

Activity

  1. Zekfad
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Feb 24, 2023
  2. DanTup
    added this to the v3.60.0 milestone on Feb 27, 2023
  3. DanTup
    added
    in editorRelates to code editing or language features
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Feb 27, 2023

  4. DanTup commented on Feb 27, 2023

    @DanTup
    DanTup
    on Feb 27, 2023
    Member

    I've got a change open at https://dart-review.googlesource.com/c/sdk/+/285625 for this.

    Feb-27-2023 13-10-56

    (note: there's some weirdness with navigation not always working in VS Code - I've filed microsoft/vscode#174912 to try and get to the bottom of that).

  5. DanTup commented on Feb 27, 2023

    @DanTup
    DanTup
    on Feb 27, 2023
    Member

    Also note: this change is in the SDK, so the fix will show up with a future Dart/Flutter SDK release rather than a VS Code extension update.

  6. copybara-service
    added a commit that references this issue on Feb 27, 2023

    [analysis_server] Split InlayHints up for type arguments

    88d277a

  7. DanTup commented on Feb 27, 2023

    @DanTup
    DanTup
    on Feb 27, 2023
    Member

    Fixed by dart-lang/sdk@88d277a.

  8. DanTup
    closed this as completedon Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions