Repository navigation
"Use curly braces" quick fix removes comment before the expression guearded by if statement #4440
Description
Describe the bug
If a comment precedes expression guarded by if statement without curly braces, the "Use curly braces" quick fix removes the comment.
To Reproduce
- Make sure
curly_braces_in_flow_control_structureslint rule is enforced - Insert the following code:
if (identical(true, false))
// This is a nice comment.
throw Exception();- Open quick fixes suggestions in VSCode at the if statement line.
- Apply "Use curly braces" fix.
The resulting code is
if (identical(true, false)) {
throw Exception();
}Expected behavior
The resulting code should be:
if (identical(true, false)) {
// This is a nice comment.
throw Exception();
}Please complete the following information:
- Operating System and version: MacOS 13.1 (Ventura)
- VS Code version: 1.76.1 (Universal)
- Dart extension version: v3.60.1
- Dart/Flutter SDK version: 2.19.2 / 3.7.3
Activity
[analysis_server] Retain body's leading comments when adding curly br…
DanTup commentedon Mar 16, 2023
Thanks for the report! This is fixed by dart-lang/sdk@454219b.
The change is in the Dart analysis server so will ship with a future Dart/Flutter SDK release rather than show up in the VS Code extension release.