Skip to content

Adopt new VM Service APIs to allow multiple clients to work with the debugger #4481

Closed

Description

@DanTup

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Apr 4, 2023
  2. added this to the v3.66.0 milestone on Apr 4, 2023
  3. modified the milestones: v3.66.0, v3.68.0 on May 26, 2023
  4. modified the milestones: v3.68.0, v3.70.0 on Jun 28, 2023
  5. modified the milestones: v3.70.0, v3.72.0 on Jul 25, 2023
  6. modified the milestones: v3.72.0, v3.74.0 on Aug 29, 2023
  7. modified the milestones: v3.74.0, v3.76.0 on Sep 26, 2023
  8. modified the milestones: v3.76.0, v3.78.0 on Oct 30, 2023
  9. modified the milestones: v3.78.0, On Deck on Nov 27, 2023
  10. DanTup commented on Aug 20, 2024

    @DanTup
    MemberAuthor

    The new APIs were adopted in dart-lang/sdk@93556ae. We should do some testing using the DevTools debugger to ensure breakpoints work correctly during reloads etc., and then remove hide=debugger if everything works.

  11. modified the milestones: On Deck, v3.96.0 on Aug 20, 2024
  12. DanTup commented on Aug 27, 2024

    @DanTup
    MemberAuthor

    I did some testing with the DevTools debugger open, and things seem to work as expected - during a reload, everything remains paused while breakpoints are sent and then unpauses. I'm going to remove hide=debugger from DevTools and consider this done. As long as the other debuggers involved are also using readyToResume, I believe multiple debuggers should be safe now.

  13. added a commit that references this issue on Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions