Like named constructor, add constructor modifier for unnamed constructor

[Screenshots Attached Below]
I want to apply distinct color to all types of constructors i.e. named or unnamed so that I can quickly spot them wherever they are declared or used. Currently as named constructor has constructor modifier so I have used the following coloring customization:

"method.constructor:dart": { 
    "bold": true,
    "foreground": "#2e32ff",
  },

Similar to named constructor, if there was constructor modifier for unnamed constructor then I could have used the following:

"class.constructor:dart": {
    "bold": true,
    "foreground": "#2e32ff",
  },

First look at the Named Constructor that how nicely it has constructor modifier:

Now look at the Unnamed Constructor that it doesn't have constructor modifier:

This seems like a bug. In constructor invocations the class names already have this modifier, so the current behaviour is not consistent:

class A {
  A();
  A.named();
}

final a1 = A(); // A has constructor modifier
final a2 = A.named(); // both A and named have constructor modifier

For consistency, A in both constructor declarations should have the modifier.

I think we might also be missing declaration modifiers on constructors, I'll verify that and file an issue if so.

@DanTup

@DanTup You never disappoint 🥇
Thank you for adding this to v3.64.0 milestone!

@shujaatak

@shujaatak just to set expectations, this change will ship in the Dart SDK because that's where the semantic tokens are produced. For small changes like this one, I tend to include them in the release notes for the month in which they're done under a note of ("these changes require an SDK update") so that users of the beta/master branches are aware of them (and can test them).

This means it might be longer before the fix will be available in stable SDKs.

@DanTup

The wait will be worth it!
Thank you @DanTup

[analysis_server] Add missing "constructor" semantic token modifiers …

Fixed by dart-lang/sdk@3069c4f. This change ships in a future SDK update (and not a Dart-Code update).

Navigation Menu

Repository navigation

Like named constructor, add `constructor` modifier for unnamed constructor #4495

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Like named constructor, add constructor modifier for unnamed constructor #4495

Description

Activity

DanTup commented on Apr 17, 2023

shujaatak commented on Apr 17, 2023

DanTup commented on Apr 17, 2023

shujaatak commented on Apr 17, 2023

DanTup commented on Apr 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Like named constructor, add `constructor` modifier for unnamed constructor #4495