Skip to content

Developing in the Dart SDK repo checked out as a git worktree triggers unwanted "pub" runs #4501

Closed
Closed
Developing in the Dart SDK repo checked out as a git worktree triggers unwanted "pub" runs#4501
Labels
is bug
Milestone
v3.64.0

Description

@DanTup
DanTup
opened on Apr 20, 2023

See dart-lang/sdk#52067 (comment).

We're finding the git root by looking only for files, but in this case .git is a file.

Activity

  1. DanTup
    added
    is bug
    on Apr 20, 2023
  2. DanTup
    added this to the v3.64.0 milestone on Apr 20, 2023

  3. DanTup commented on Apr 20, 2023

    @DanTup
    DanTup
    on Apr 20, 2023
    MemberAuthor

    Should we change this check to only look for DEPS? See dart-lang/sdk#52067 (comment)

  4. DanTup
    closed this as completedin f566c99on Apr 24, 2023
  5. keertip
    added a commit that references this issue on Sep 2, 2025

    Handle the Dart SDK as a git worktree to prevent running pub

    f566c99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions