Disable addSdkToTerminalPath not working #4545

Activity

1. quyenvsp

   added

   is bug

   on May 16, 2023
2. DanTup commented on May 16, 2023

   

   DanTup

   on May 16, 2023

   Member

   More actions

   I don't seem to be able to reproduce this. The code in the extension is definitely wrapped with a check for this setting:

   Dart-Code/src/extension/extension.ts

   Lines 197 to 203 in 557630c

   	if (config.addSdkToTerminalPath) {
   	const baseSdk = workspaceContext.hasAnyFlutterProjects
   	? sdks.flutter
   	: sdks.dart;
   	const envPathPrefix = [baseSdk, "bin", path.delimiter].join(path.sep);
   	context.environmentVariableCollection.prepend("PATH", envPathPrefix);
   	}

   I notice that your paths are in a different format (you have a Windows path in your settings, but not in the which output) - are you using WSL or something?

   Could you also try clicking the trashcan icon against the affected terminal and re-create it to see if that makes a difference? I think VS Code tries to reuse terminal sessions but I don't know what it persists for them.
3. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on May 16, 2023
4. quyenvsp commented on May 16, 2023

   

   quyenvsp

   on May 16, 2023

   Author

   More actions

   Hi,

   Thank so much for your quick response. I found a solution but these are more info maybe helpful other.

   I current using windows 11 + fvm (with alias flutter = fvm flutter) + git bash for windows.

   I notice that your paths are in a different format

   It is git bash, but I used Three dot > Clear terminal for clear data so it look like that.

   Could you also try clicking the trashcan icon

   Yeah I tried on two computer but same error.

   Solution is disable addSdkToTerminalPath first then disabled Flutter / Dart plugin then enable again. It working now but I will keep tracking it more.
5. quyenvsp

   closed this as completedon May 16, 2023
6. DanTup commented on May 16, 2023

   

   DanTup

   on May 16, 2023

   Last edited by DanTup

   Member

   More actions

   Solution is disable addSdkToTerminalPath first then disabled Flutter / Dart plugin then enable again.

   hmm, that's odd. That sounds like it could be a VS Code issue - I don't think it's intended to require that.

   Would you mind filing an issue describing this at https://github.com/microsoft/vscode and CCing me so we can see if it's something they can fix (or, if it's intended, it can be clarified how we should handle this)?

   Thanks!
7. DanTup commented on May 16, 2023

   

   DanTup

   on May 16, 2023

   Member

   More actions

   Oh, apparently this is intended - there's a "persistent" flag on it. I will fix this (and figure out why I'm not seeing the same behaviour).
8. DanTup

   reopened this on May 16, 2023
9. DanTup

   added this to the v3.66.0 milestone on May 16, 2023
10. DanTup

    removed

    awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

    on May 16, 2023
11. DanTup commented on May 16, 2023

    

    DanTup

    on May 16, 2023

    Member

    More actions

    Turns out I can repro this now. I'm not sure what I did wrong earlier - although I note that after restarting VS Code I do need to click the trashcan to delete the terminal before any PATH change takes effect (so there's definitely some additional caching going on beyond this).
12. DanTup commented on May 16, 2023

    

    DanTup

    on May 16, 2023

    Member

    More actions

    Fixed by d011b9a.

    🚀React with 🚀1Reacted by Quyen Le Van
13. DanTup

    closed this as completedon May 16, 2023