Repository navigation
Flutter structured errors aren't formatted well when using SDK DAPs #4571
Description
Activity
- changed the title
[-]exceptions aren't formatted correctly[/-][+]Flutter structured errors aren't formatted well when using SDK DAPs[/+]on Jun 5, 2023 @jacob314 it turns out that we never implemented handling of structured errors in the new DAPs, we only forwarded the rendered text to the debug console as error text.
We discussed this previously and wanted to use the Flutter classes like
DiagnosticsNodeto deserialise the error, but they live inpackage:flutterand are not accessible to DAP (flutter_tools). I had tried moving them, but the full set of types they reference is quite large and would've meant moving a lot of code.Here's a small repro with the
Flutter.Errorevent JSON and how each adapter looks:Legacy:
SDK:
Improvements to this have landed in the latest Flutter master and will, ship in a future SDK.
Reacted by maciek
The console doesn't show the exceptions correctly, links are in red, not clickable,
Dart-Code-Log-2023-05-05 19-17-57.txt
with legacy DAPs:
start of the exception:
middle:
end:
currently: all of the console log looks like this with nothing clickable and not clear stacktrace.
