Skip to content

All breakpoints in a file become "unverified" when adding/removing breakpoints #4599

Closed
Closed
All breakpoints in a file become "unverified" when adding/removing breakpoints#4599
Labels
in debuggingRelates to the debug adapter or process of running debug sessionsis bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.68.0

Description

@DanTup
DanTup
opened on Jun 20, 2023

When I add or remove a breakpoint, other breakpoints in the file become unverified.

It's possible we remove and re-add them all, but I would expect them to be immediately resolved.

breakpoints.unverified.mp4

Activity

  1. DanTup
    added
    is bug
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Jun 20, 2023
  2. DanTup
    added this to the v3.68.0 milestone on Jun 20, 2023

  3. incendial commented on Jun 20, 2023

    @incendial
    incendial
    on Jun 20, 2023

    @DanTup hey, I was faster #4598 😁

  4. incendial commented on Jun 20, 2023

    @incendial
    incendial
    on Jun 20, 2023

    Ah, it's a different one? Looking into it.

  5. DanTup commented on Jun 20, 2023

    @DanTup
    DanTup
    on Jun 20, 2023
    MemberAuthor

    @incendial I just replied there - this is just unverifying, but yours are disappearing too? :(

    (I found this while trying to repro yours :) )

  6. DanTup commented on Jun 20, 2023

    @DanTup
    DanTup
    on Jun 20, 2023
    MemberAuthor

    (and what's slightly confusing is that a verified breakpoint is visible behind the execution market, but an unverified breakpoint is not - so although it looks like the one on the yellow line disappears, it doesn't, it's still there and grey once I step away)

  7. DanTup commented on Jun 20, 2023

    @DanTup
    DanTup
    on Jun 20, 2023
    MemberAuthor

    Logs for a breakpoint request that leaves things in this state..

    We removed the old breakpoints from the VM, add the new ones (and get BreakpointAdded), but we then respond with unverified:false for everything, and never generate any DAP events to mark them as verified.

    [5:45:15 PM] [DAP] [Info] ==> {"command":"setBreakpoints","arguments":{"source":{"adapterData":{"type":"@Script","id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","fixedId":true,"uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"name":"test\\widget_test.dart","path":"c:\\Dev\\Test Projects\\flutter_counter\\test\\widget_test.dart"},"lines":[16,20,23,24,27,28],"breakpoints":[{"line":16},{"line":20},{"line":23},{"line":24},{"line":27},{"line":28}],"sourceModified":false},"type":"request","seq":14}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"912","method":"removeBreakpoint","params":{"isolateId":"isolates/478628281828835","breakpointId":"breakpoints/1"}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointRemoved","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515320,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/1","enabled":true,"breakpointNumber":1,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":663,"line":16,"column":18}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Success"},"id":"912"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"913","method":"removeBreakpoint","params":{"isolateId":"isolates/478628281828835","breakpointId":"breakpoints/2"}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointRemoved","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515322,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/2","enabled":true,"breakpointNumber":2,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":799,"line":20,"column":17}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Success"},"id":"913"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"914","method":"removeBreakpoint","params":{"isolateId":"isolates/478628281828835","breakpointId":"breakpoints/3"}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointRemoved","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515323,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/3","enabled":true,"breakpointNumber":3,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":900,"line":23,"column":27}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Success"},"id":"914"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"915","method":"removeBreakpoint","params":{"isolateId":"isolates/478628281828835","breakpointId":"breakpoints/4"}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointRemoved","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515324,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/4","enabled":true,"breakpointNumber":4,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":938,"line":24,"column":18}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Success"},"id":"915"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"916","method":"removeBreakpoint","params":{"isolateId":"isolates/478628281828835","breakpointId":"breakpoints/5"}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointRemoved","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515326,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/5","enabled":true,"breakpointNumber":5,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":1014,"line":27,"column":17}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Success"},"id":"916"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"917","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":16}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515332,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/6","enabled":true,"breakpointNumber":6,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":663,"line":16,"column":18}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/6","enabled":true,"breakpointNumber":6,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":663,"line":16,"column":18}},"id":"917"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"918","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":20}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515337,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/7","enabled":true,"breakpointNumber":7,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":799,"line":20,"column":17}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/7","enabled":true,"breakpointNumber":7,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":799,"line":20,"column":17}},"id":"918"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"919","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":23}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515343,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/8","enabled":true,"breakpointNumber":8,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":900,"line":23,"column":27}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/8","enabled":true,"breakpointNumber":8,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":900,"line":23,"column":27}},"id":"919"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"920","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":24}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515348,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/9","enabled":true,"breakpointNumber":9,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":938,"line":24,"column":18}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/9","enabled":true,"breakpointNumber":9,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":938,"line":24,"column":18}},"id":"920"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"921","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":27}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515353,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/10","enabled":true,"breakpointNumber":10,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":1014,"line":27,"column":17}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/10","enabled":true,"breakpointNumber":10,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":1014,"line":27,"column":17}},"id":"921"}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] ==> [VM] {"jsonrpc":"2.0","id":"922","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":28}}
[5:45:15 PM] [DAP] [Info] <== {"seq":2032,"type":"response","body":{"breakpoints":[{"id":100005,"verified":false},{"id":100006,"verified":false},{"id":100007,"verified":false},{"id":100008,"verified":false},{"id":100009,"verified":false},{"id":100010,"verified":false}]},"command":"setBreakpoints","request_seq":14,"success":true}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515358,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/11","enabled":true,"breakpointNumber":11,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":1057,"line":28,"column":17}}}}}
[5:45:15 PM] [General] [Info] [flutter_counter (Windows)] <== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/11","enabled":true,"breakpointNumber":11,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":1057,"line":28,"column":17}},"id":"922"}

  8. DanTup commented on Jun 20, 2023

    @DanTup
    DanTup
    on Jun 20, 2023
    MemberAuthor

    This seems to be a timing/ordering issue. The BreakpointAdded event comes before the response to add the breakpoint:

    
// Send a request to add a breakpoint to the VM
==> [VM] {"jsonrpc":"2.0","id":"917","method":"addBreakpointWithScriptUri","params":{"isolateId":"isolates/478628281828835","scriptUri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","line":16}}
// Get the BreakpointAdded event
<== [VM] {"jsonrpc":"2.0","method":"streamNotify","params":{"streamId":"Debug","event":{"type":"Event","kind":"BreakpointAdded","isolate":{"type":"@Isolate","id":"isolates/478628281828835","name":"main","number":"478628281828835","isSystemIsolate":false,"isolateGroupId":"isolateGroups/9029525345721931127"},"timestamp":1687279515332,"breakpoint":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/6","enabled":true,"breakpointNumber":6,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart"},"tokenPos":663,"line":16,"column":18}}}}}
// Get the response from the request to add the  breakpoint
<== [VM] {"jsonrpc":"2.0","result":{"type":"Breakpoint","fixedId":true,"id":"breakpoints/6","enabled":true,"breakpointNumber":6,"resolved":true,"location":{"type":"SourceLocation","script":{"type":"@Script","fixedId":true,"id":"libraries/@17238642/scripts/file%3A%2F%2F%2FC%3A%2FDev%2FTest%2520Projects%2Fflutter_counter%2Ftest%2Fwidget_test.dart/188d9b2237c","uri":"file:///C:/Dev/Test%20Projects/flutter_counter/test/widget_test.dart","_kind":"kernel"},"tokenPos":663,"line":16,"column":18}},"id":"917"}

    It's only after we get the response from the request that we know the ID for this breakpoint, so when handling BreakpointAdded we fail to find the breakpoint so can't tell the client it's resolved.

    We need to handle getting a BreakpointAdded event for a pending breakpoint request, and delay processing it until the request has completed. We already kinda do this with sending the response, but it currently relies the request completed first, that was only to ensure the correct ordering of the output.

  9. copybara-service
    added a commit that references this issue on Jun 22, 2023

    [dds/dap] Ensure breakpoint modifications do not drop resolution events

    c2a4f8e

  10. DanTup commented on Jun 22, 2023

    @DanTup
    DanTup
    on Jun 22, 2023
    MemberAuthor

    Fixed by dart-lang/sdk@c2a4f8e

  11. DanTup
    closed this as completedon Jun 22, 2023
  12. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions