Skip to content

Go to Definition doesn't work with a selection #4619

Closed

Description

@DanTup

I thought this had come up before and been fixed, but I can't find any evidence of that. Ctrl+Click and F12 work fine on this symbol, but not if the entire thing is selected:

Screenshot 2023-06-29 151333

Activity

  1. added
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    on Jun 29, 2023
  2. added this to the v3.70.0 milestone on Jun 29, 2023
  3. DanTup commented on Jul 25, 2023

    @DanTup
    MemberAuthor

    Seems to be that the end of the selection is used, and we don't handle that location for generic types:

    class A1 {}
    class A2<T> {}
    
    A1^ a1; // works
    A2^<String> a2; // doesn't work
  4. DanTup commented on Jul 25, 2023

    @DanTup
    MemberAuthor
  5. modified the milestones: v3.70.0, v3.72.0 on Jul 31, 2023
  6. DanTup commented on Aug 6, 2023

    @DanTup
    MemberAuthor

    Fixed by dart-lang/sdk@7f0ac78, ships in the SDK.

  7. added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions