Hovering over a for loop variable does not show its type #4627

Activity

1. incendial

   added

   is bug

   on Jul 4, 2023
2. incendial commented on Jul 4, 2023

   

   incendial

   on Jul 4, 2023

   Author

   More actions

   Feels like it's related to #4626
3. DanTup

   added this to the v3.70.0 milestone on Jul 5, 2023
4. DanTup

   added

   in editorRelates to code editing or language featuresRelates to code editing or language features

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

   on Jul 5, 2023
5. DanTup commented on Jul 5, 2023

   

   DanTup

   on Jul 5, 2023

   Member

   More actions

   I suspect same cause, but different code. Opened a fix for this one at https://dart-review.googlesource.com/c/sdk/+/312441
6. incendial commented on Jul 5, 2023

   

   incendial

   on Jul 5, 2023

   Last edited by incendial

   Author

   More actions

   Ah, these DeclaredIdentifier's ... 🥲
   Recently discovered that several rules in DCM were not covering them at all. Honestly, I'm really surprised it's a separate type of node (and not a variable declaration or it's variance).
7. DanTup commented on Jul 5, 2023

   

   DanTup

   on Jul 5, 2023

   Member

   More actions

   I don't know all the details, but there seem to be some differences between the classes (for ex. VariableDeclaration has things like an initializer and is documented as always being a child of VariableDeclarationList, so it doesn't have keyword because that's on the list).

   I don't know if something changed here recently though, I feel like I've seen a few issues related to this recently (such as the one you linked above - which had a similar fix) - although for loops are definitely not new!
8. copybara-service

   added a commit that references this issue on Jul 5, 2023

   [analysis_server] Handle hovers for identifiers declared in for loops

   ...

   28ea45c
9. DanTup commented on Jul 5, 2023

   

   DanTup

   on Jul 5, 2023

   Member

   More actions

   This is fixed by dart-lang/sdk@28ea45c. It's in the server so will show up in a future SDK release.
10. DanTup

    closed this as completedon Jul 5, 2023