Skip to content

Suggest installing the ARB extension when editing arb files #4719

Closed

Description

@DanTup

The ARB editor extension provides language support for ARB files used for translating Flutter apps.

Since VS Code has removed recommending extensions based on file extension we should consider showing a notification when a Flutter developer opens an ARB file offering to install the extension.

Something like:

The ARB Editor extension can help with editing '.arb' files
[Install Extension] [Don't Show Again]

If the user does not interact with the notification at all (because they might not have noticed it and VS Code hides it after ~10s) we could re-show it only after some snooze period.

It should be shown:

  • only if the extension is not already installed
  • only if we have detected a Dart or Flutter project (Dart doesn't currently use ARB files? @mosuem)

Questions:

  • How long should we snooze before showing it again if not interacted with?
  • Should we show it some maximum number of times and then give up (eg. if a user keeps ignoring it, perhaps they expect us to stop asking?)

(cc @jacob314 @anderdobo)

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in editorRelates to code editing or language features
    on Sep 5, 2023
  2. added this to the v3.74.0 milestone on Sep 5, 2023
  3. mosuem commented on Sep 5, 2023

    @mosuem

    only if we have detected a Flutter project (Dart doesn't currently use ARB files?)

    It does, for example using package:intl_translation. Dart-Code has mechanisms for detecting if the workspace contains a Dart project I assume?

  4. DanTup commented on Sep 5, 2023

    @DanTup
    MemberAuthor

    Ah, in that case we should show it for either project type. Dart-Code detects all projects and determines whether each is plain Dart or Flutter.

  5. modified the milestones: v3.74.0, v3.76.0 on Oct 2, 2023
  6. modified the milestones: v3.76.0, v3.78.0 on Oct 30, 2023
  7. modified the milestones: v3.78.0, v3.80.0 on Nov 27, 2023
  8. DanTup commented on Dec 20, 2023

    @DanTup
    MemberAuthor

    I've added this:

    arb.mp4

    It's using the same rules as other extension recommendations (via DevTools server). If the user clicks "No Thanks" we will not prompt again (I don't think we should just snooze, I think it will feel spammy).

    If they ignore the prompt, we will show it again, but not in the same session.

    @mosuem @anderdobo @jacob314 let me know if you want any tweaks to this (the wording, or the behaviour).

  9. jacob314 commented on Dec 20, 2023

    @jacob314

    Looks great! Thanks for adding this.

  10. mosuem commented on Jan 2, 2024

    @mosuem

    Wow, thanks so much for adding this @DanTup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions