Closure completions are not showing up in VS Code #4837

Activity

1. DanTup

   added

   is bug

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Nov 14, 2023
2. DanTup

   added this to the v3.78.0 milestone on Nov 14, 2023
3. DanTup commented on Nov 14, 2023

   

   DanTup

   on Nov 14, 2023

   MemberAuthor

   More actions

   From the log... labels are missing:

   {
   	"insertTextFormat": 2,
   	"kind": 2,
   	"label": "",
   	"sortText": "9099",
   	"textEditText": "(a, b) {\n      $0\n    },"
   },
   {
   	"insertTextFormat": 2,
   	"kind": 2,
   	"label": "",
   	"sortText": "9099",
   	"textEditText": "(a, b) => $0,"
   },

   Something is likely going wrong with the mapping - this also suggests we have no LSP tests for closures.
4. DanTup

   added

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   on Nov 14, 2023
5. DanTup commented on Nov 14, 2023

   

   DanTup

   on Nov 14, 2023

   MemberAuthor

   More actions

   https://dart-review.googlesource.com/c/sdk/+/335822
6. DanTup

   added

   relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

   on Nov 14, 2023
7. DanTup

   changed the title [-]Closure completions are not showing up in VS Code[/-] [+]Closure completions are not showing up in VS Code in bleeding-edge SDKs[/+] on Nov 14, 2023
8. copybara-service

   added a commit that references this issue on Nov 14, 2023

   [analysis_server] Fix missing closure completions in LSP

   ...

   28d9ac0
9. DanTup commented on Nov 15, 2023

   

   DanTup

   on Nov 15, 2023

   MemberAuthor

   More actions

   Fixed by dart-lang/sdk@28d9ac0

   🚀React with 🚀1Reacted by Felipe Morschel
10. DanTup

    closed this as completedon Nov 15, 2023
11. DanTup

    changed the title [-]Closure completions are not showing up in VS Code in bleeding-edge SDKs[/-] [+]Closure completions are not showing up in VS Code[/+] on Nov 20, 2023
12. DanTup commented on Nov 20, 2023

    

    DanTup

    on Nov 20, 2023

    MemberAuthor

    More actions

    This came up in #4845 too.

    @bwilkerson @jacob314 FYI - when I fixed this last week I thought the bug had only made bleeding-edge SDKs, but apparently I got the branch date wrong and the bug shipped in stable.

    I don't know if it meets the bar for a cherry-pick, but it might may come up a lot given how common function parameters are in Flutter. The actual fix is pretty trivial (see dart-lang/sdk@28d9ac0).
13. DanTup

    pinned this issue on Nov 20, 2023
14. DanTup commented on Nov 25, 2023

    

    DanTup

    on Nov 25, 2023

    Last edited by DanTup

    MemberAuthor

    More actions

    Since this issue is being raised a lot, here's a summary that I can link to from other issues I'm closing as a dupe.

    Edit: 2023-12-01: This bug was in the Dart 3.2 / Flutter 3.16 SDK releases and a fix has been hot-fixed into Dart 3.2.2 / Flutter 3.16.2.

    If you're still seeing this, please update to the latest Dart/Flutter and restart VS Code.
15. copybara-service

    added a commit that references this issue on Nov 28, 2023

    [stable] [analysis_server] Fix missing closure completions in LSP

    ...

    2c61450
16. DanTup

    unpinned this issue on Dec 4, 2023