Code Preview Broken for Multi-Line Compound Declaration

The Issue

The Code Preview (shown by moving the cursor over a symbol whilst holding Cmd ⌘) shows the code preview for the first symbol in a multiline compound declartion.

To Reproduce

Copy the following:

late final textAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 500),
    ),
    healthAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 200),
      reverseDuration: const Duration(milliseconds: 100),
    ),
    playPauseButtonAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 400),
    ),
    uiAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 1000),
    ),
    menuAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 150),
    ),
    endScreenAnimationController = AnimationController(
      vsync: this,
      duration: const Duration(milliseconds: 400),
    );

Then, type endScreenAnimationController, and move the cursor over a symbol whilst holding Cmd ⌘ to show the symbol preview. The symbol preview will show the first line of compound declaration, instead of the line where endScreenAnimationController is declared.

Thanks, I can repro this:

Seems like in the Definition response we return the whole declaration list range and not only the single variable declaration:

{
    "id": 204,
    "jsonrpc": "2.0",
    "result": [
        {
            "originSelectionRange": {
                "end": { "character": 9, "line": 14 },
                "start": { "character": 8, "line": 14 }
            },
            "targetRange": {
                "end": { "character": 3, "line": 11 },
                "start": { "character": 0, "line": 8 } // should be 10
            },
            "targetSelectionRange": {
                "end": { "character": 5, "line": 10 },
                "start": { "character": 4, "line": 10 }
            },
            "targetUri": "file:///C:/Dev/Test%20Projects/Archive-2024-01/dart_sample/test/good_test.dart"
        }
    ]
}

Okay, thanks!

Also, would it be possible to show the first part of the declaration in the preview?

For example, in your example above, could you show var b?

Unfortunately not.. VS Code just asks us for the range of the definition and then it goes and reads the file contents for that range and shows it here.

If the declaration is a single variable, we could still expand it to be the whole declaration, but otherwise it will only be the range from the start of the variable name to the end of the value - we can't provide multiple ranges.

[analysis_server] Don't expand variable declarations to their lists i…

This is fixed by dart-lang/sdk@0b170c7. The change is in the Dart analysis server so will show up in a future Dart/Flutter SDK release (rather than a Dart-Code extension release).

Navigation Menu

Repository navigation

Code Preview Broken for Multi-Line Compound Declaration #4968

The Issue

To Reproduce

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Code Preview Broken for Multi-Line Compound Declaration #4968

Description

The Issue

To Reproduce

Activity

DanTup commented on Jan 31, 2024

Number-3434 commented on Jan 31, 2024

DanTup commented on Jan 31, 2024

DanTup commented on Apr 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions