You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add support for spawning the Dart Tooling Daemon and providing the URI to DevTools #4984
@kenzieschmoll@CoderDake this is essentially done (at least, starting the daemon, setting the IDE roots, and passing the URI to DevTools.. I'm not sure if there's more VS Code needs to do at this point?).
I'll push it out in a pre-release of the extension soon - but I'd like flutter/devtools#7191 to land first, just to avoid any issues if using a local custom DevTools with it enabled.
For now, it's behind a flag because I'd like some additional testing beyond my own before we enable it.
@kenzieschmoll@CoderDake I pushed a pre-release version of the extension that includes this today (v3.83.20240220). It's still currently behind a VS Code settings flag:
"dart.experimentalToolingDaemon": true,
You'll know when the daemon is running because it'll be in the language status area:
Let me know if you want to do some testing before I remove the flag (even without the flag, it'll only show up for Dart SDK >= 3.4.0-139.
Thanks - do you want me to remove the experimental flag (so from the next release, everyone on master will be spawning the daemon), or do you want me to leave it until there's been more work done (like testing it over longer sessions) first?
(part of me thinks the sooner we enable it the sooner we'll find issues, but part of me also worries about unleashing crashing bugs because so far it's had very limited testing 😄)
@DanTup
DTD is pretty low surface area, so even if we have issues with it crashing, it should effect any vital behaviours.
Right now the only behaviours would be in development for extensions being created. :)
Today's pre-release (v3.83.20240228) removes the flag from this. Please upgrade and let me know if you spot any issues (a stable release with this is likely later in the week).
Activity
DanTup commentedon Feb 14, 2024
Need to remove the check noted above.
DanTup commentedon Feb 15, 2024
@kenzieschmoll @CoderDake this is essentially done (at least, starting the daemon, setting the IDE roots, and passing the URI to DevTools.. I'm not sure if there's more VS Code needs to do at this point?).
I'll push it out in a pre-release of the extension soon - but I'd like flutter/devtools#7191 to land first, just to avoid any issues if using a local custom DevTools with it enabled.
For now, it's behind a flag because I'd like some additional testing beyond my own before we enable it.
DanTup commentedon Feb 20, 2024
@kenzieschmoll @CoderDake I pushed a pre-release version of the extension that includes this today (v3.83.20240220). It's still currently behind a VS Code settings flag:
You'll know when the daemon is running because it'll be in the language status area:
Let me know if you want to do some testing before I remove the flag (even without the flag, it'll only show up for Dart SDK >=
3.4.0-139.CoderDake commentedon Feb 21, 2024
Tested myself and LGTM!
Also looked at the PR that added the changes and it looks right on to me :D
DanTup commentedon Feb 21, 2024
Thanks - do you want me to remove the experimental flag (so from the next release, everyone on master will be spawning the daemon), or do you want me to leave it until there's been more work done (like testing it over longer sessions) first?
(part of me thinks the sooner we enable it the sooner we'll find issues, but part of me also worries about unleashing crashing bugs because so far it's had very limited testing 😄)
CoderDake commentedon Feb 27, 2024
@DanTup
DTD is pretty low surface area, so even if we have issues with it crashing, it should effect any vital behaviours.
Right now the only behaviours would be in development for extensions being created. :)
So I think we are ok to expose it :)
DanTup commentedon Feb 28, 2024
Today's pre-release (v3.83.20240228) removes the flag from this. Please upgrade and let me know if you spot any issues (a stable release with this is likely later in the week).