Skip to content

Enabling the legacy protocol for Dart 3.3 results in no completions #5001

Closed

Description

@DanTup

Completion tests are failing on Dart 3.3 when using the legacy protocol due to the removal of completion.getSuggestions.

Rather than migrating to the new APIs, we should disable using the legacy protocol on Dart 3.3 onwards. LSP has been stable and the default for a long time and we've not been updating the legacy client here to keep up with any new features.

As part of removing this, we should set up a bot that runs the tests using Dart 3.2 to ensure we're still testing the legacy protocol for older SDKs (because otherwise no legacy tests would run).

Activity

  1. added this to the v3.84.0 milestone on Feb 21, 2024
  2. changed the title [-]No completions when using the legacy protocol on Dart 3.3[/-] [+]Enabling the legacy protocol for Dart 3.3 results in no completions[/+] on Feb 21, 2024
  3. added
    in editorRelates to code editing or language features
    on Feb 21, 2024
  4. DanTup commented on Feb 22, 2024

    @DanTup
    MemberAuthor

    Fixed by 5ba49f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions