Missing contextual information when hovering over extension type declarations

Consider the following example:

extension type ET(Future<void> value) implements Future<void> {}

class SomeClass implements String {
  const SomeClass();
}

enum SomeEnum { first }

both enum and class have contextual info when hovering over their name (e.g. that it's a class and implements String):

for extension types this tooltip has only the name:

Please complete the following information:

Dart Code extension: 3.82.0

App: Visual Studio Code
App Host: desktop
Version: mac 1.86.2

Workspace type: Dart (LSP)

Dart (3.3.0): /Users/incendial/Desktop/flutter/bin/cache/dart-sdk
Flutter (3.19.1): /Users/incendial/Desktop/flutter (No device)

Also noticed that for cmd + hover extension types have a bit confusing constructor (without the extension type name)

It gets a bit worse for named constructors

When classes, for example, have the name

Is it by design or you'd want this to be fixed?

The example above is not for declaration, but for instantiation:

void fn() {
  ET.named();
  SomeClass();
}

And if the extension type is const, this info is not displayed (but for a class it's there):

extension type const ET.named(Future<void> value) implements Future<void> {}

[analyzer] Add element display string for extension types

Fixed by dart-lang/sdk@8a62f4a, but ships in an SDK release.

Oops, I missed some of the extra things noted above, I need to check if the fix covered them too.

@incendial

@incendial do you have a complete code sample to trigger the bad preview on the named constructor of an extension type?

I can reproduce the issue for unnamed constructors:

And I understand the cause of this (which seems specific to the default constructor), however I can't reproduce for named constructors:

extension type ET.named(Future<void> value) implements Future<void> {}

void fn() {
  ET.named();
}

Perfect - thanks! I didn't realise we could put the name there like that 😄

It can also be const

extension type const ET.named(Future<void> value) implements Future<void> {}

With my new fix, that shows up too:

The issue is basically the "primary constructor" of an extension type, which has a small "codeRange". My change expands this to be the whole declaration (so it works the same as for an implied unnamed constructor on a class).

[analysis_server] Improve the target range for extension type primary…

Fixe dby dart-lang/sdk@c22f054. The change is in the Dart SDK so will ship in a future SDK release (rather than a Dart-Code release).

Navigation Menu

Repository navigation

Missing contextual information when hovering over extension type declarations #5005

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Missing contextual information when hovering over extension type declarations #5005

Description

Activity

incendial commented on Feb 24, 2024

incendial commented on Feb 24, 2024

incendial commented on Feb 24, 2024

DanTup commented on Feb 28, 2024

DanTup commented on Feb 28, 2024

DanTup commented on Feb 28, 2024

incendial commented on Feb 28, 2024

DanTup commented on Feb 28, 2024

incendial commented on Feb 28, 2024

DanTup commented on Feb 28, 2024

DanTup commented on Apr 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions