Skip to content

Disable shellExecute in safeSpawn() when we know we don't need it #5018

Closed
Closed
Disable shellExecute in safeSpawn() when we know we don't need it#5018
Labels
is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
Milestone
v3.88.0

Description

@DanTup
DanTup
opened on Feb 29, 2024

We only need it for shell scripts (which is generally just flutter, but we should review all call sites).

See #5017

This may reduce the chances of leaving orphaned processes around.

Activity

  1. DanTup
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Feb 29, 2024
  2. DanTup
    added this to the v3.86.0 milestone on Feb 29, 2024
  3. DanTup
    modified the milestones: v3.86.0, v3.88.0 on Apr 2, 2024
  4. DanTup
    added a commit that references this issue on Apr 3, 2024

    Limit shell execute only to .bat on Windows

    8b7b92b
  5. DanTup
    closed this as completedin b217782on Apr 3, 2024
  6. rizkyhaksono
    added a commit that references this issue on Apr 6, 2024

    Limit shell execute only to .bat on Windows

    b217782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions