Repository navigation
Duplicate fields in debugger view #5128
Description
Describe the bug
In this debugger variable view, of a RevenueCat object hierarchy, you can see a bunch of duplicate field entries:
The _$OfferingImpl class that contains the fields that are displayed duplicated is a "Freezed" generated class.
To Reproduce
You'd have to set up a whole RevenueCat-enabled project to reproduce these conditions, so reproducing this may be a lot of work...
Expected behavior
Fields should only ever show once
Please complete the following information:
Workspace Environment
Dart Code extension: 3.89.20240513
Flutter extension: 3.89.20240501 (activated)
App: Visual Studio Code
App Host: desktop
Version: linux 1.89.1
Workspace type: Dart, Flutter (LSP) (Multiroot)
Dart (3.4.0-282.3.beta): /opt/flutter/bin/cache/dart-sdk
Flutter (3.22.0-0.3.pre): /opt/flutter (Pixel 7 Pro (android-arm64/android))
Output from 'dart info'
/opt/flutter/bin/cache/dart-sdk/bin/dart info
If providing this information as part of reporting a bug, please review the information
below to ensure it only contains things you're comfortable posting publicly.
General info
- Dart 3.4.0-282.3.beta (beta) (Tue Apr 23 15:11:21 2024 +0000) on "linux_x64"
- on linux / Linux 6.8.10-300.fc40.x86_64 Code already includes yaml support, doesn't need providing #1 SMP PREEMPT_DYNAMIC Fri May 17 21:20:54 UTC 2024
- locale is en_US.utf8
Project info
- sdk constraint: '>=3.3.0'
- dependencies: auto_size_text, bouncy_widget, boxy, bubble, cached_network_image, carousel_slider, chat_message_timestamp, collection, cronet_http, cross_file, cupertino_http, cupertino_icons, dart_emoji, delayed_display, device_info_plus, dio, dio_smart_retry, email_validator, exif, extended_image, file_picker, firebase_analytics, firebase_app_check, firebase_auth, firebase_core, firebase_crashlytics, firebase_in_app_messaging, firebase_messaging, firebase_ui_auth, firebase_ui_oauth_apple, firebase_ui_oauth_facebook, firebase_ui_oauth_google, flutter, flutter_cache_manager, flutter_email_sender, flutter_facebook_auth, flutter_google_maps_webservices, flutter_google_places_sdk, flutter_image_utilities, flutter_localizations, flutter_persistent_value_notifier, flutter_staggered_grid_view, flutter_svg, flutter_value_notifier_stateful_widget, fluttericon, fluttertoast, geocoding, geolocator, google_fonts, google_maps_flutter, google_maps_webapi, google_sign_in, http, image_crop, image_picker, image_picker_android, image_picker_platform_interface, intl, jiffy, keep_keyboard_popup_menu, latlong2, line_awesome_flutter, logger, maps_launcher, material_dialogs, outlined_text, package_info_plus, package_signature, path_provider, persistent_bottom_nav_bar_v2, pexels_api, pinch_to_zoom_scrollable, provider, purchases_flutter, serverpod_auth_client, serverpod_auth_email_flutter, serverpod_auth_firebase_flutter, serverpod_auth_shared_flutter, serverpod_client, serverpod_flutter, serverpod_serialization, share_plus, shared_preferences, syncfusion_flutter_datepicker, timezone, url_launcher
- dev_dependencies: dependency_validator, flutter_launcher_icons, flutter_lints, flutter_native_splash, flutter_test, lints
- elided dependencies: 1
Process info
| Memory | CPU | Elapsed time | Command line |
|---|---|---|---|
| 505 MB | 0.0% | 1-06:28:52 | dart --enable-vm-service=0 --pause_isolates_on_start --disable-dart-dev -DSILENT_VM_SERVICE=true --write-service-info=file:/vm.json --pause_isolates_on_exit --enable-asserts /main.dart |
| 700 MB | 0.0% | 1-02:39:41 | dart ../serverpod_cli.dart generate --watch |
| 83 MB | 0.0% | 1-06:28:52 | dart debug_adapter |
| 66 MB | 0.0% | 2-04:56:35 | dart devtools --machine --allow-embedding --dtd-uri ws:/2dc3zZ1q5iCzrf6H |
| 64 MB | 0.0% | 1-10:21:48 | dart devtools --machine --allow-embedding --dtd-uri ws:/4BtjkJgBCxnUWaPp |
| 67 MB | 0.0% | 2-04:56:39 | dart devtools --machine --allow-embedding --dtd-uri ws:/6UZRO6HYg3iwvXMt |
| 12361 MB | 1.2% | 2-04:56:39 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.89.20240513 |
| 17807 MB | 0.5% | 2-04:56:35 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.89.20240513 |
| 12952 MB | 0.7% | 1-10:21:48 | dart language-server --protocol=lsp --client-id=VS-Code --client-version=3.89.20240513 |
| 75 MB | 0.0% | 2-04:56:39 | dart tooling-daemon --machine |
| 76 MB | 0.0% | 2-04:56:35 | dart tooling-daemon --machine |
| 76 MB | 0.0% | 1-10:21:48 | dart tooling-daemon --machine |
| 94 MB | 0.0% | 2-04:56:39 | flutter_tools.snapshot daemon |
| 93 MB | 0.0% | 2-04:56:35 | flutter_tools.snapshot daemon |
| 92 MB | 0.0% | 1-10:21:48 | flutter_tools.snapshot daemon |
| 78 MB | 0.1% | 13:25 | flutter_tools.snapshot debug_adapter |
| 647 MB | 0.8% | 13:24 | flutter_tools.snapshot run --machine --start-paused -d 29161FDH300BLP --devtools-server-address http:/ --target /main.dart |
Output from 'flutter doctor'
/opt/flutter/bin/flutter doctor -v
[✓] Flutter (Channel beta, 3.22.0-0.3.pre, on Fedora Linux 40 (Workstation Edition) 6.8.10-300.fc40.x86_64, locale en_US.utf8)
• Flutter version 3.22.0-0.3.pre on channel beta at /opt/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 87b652410d (5 weeks ago), 2024-04-23 21:41:18 -0500
• Engine revision b4bfd45986
• Dart version 3.4.0 (build 3.4.0-282.3.beta)
• DevTools version 2.34.3
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /home/luke/Android/Sdk
• Platform android-34, build-tools 34.0.0
• Java binary at: /opt/android-studio/jbr/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• clang version 18.1.6 (Fedora 18.1.6-3.fc40)
• cmake version 3.28.2
• ninja version 1.11.1
• pkg-config version 2.1.0
[✓] Android Studio (version 2023.3)
• Android Studio at /opt/android-studio
• Flutter plugin version 79.0.2
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] VS Code (version 1.89.1)
• VS Code at /usr/share/code
• Flutter extension version 3.89.20240501
[✓] Connected device (3 available)
• Pixel 7 Pro (mobile) • 29161FDH300BLP • android-arm64 • Android 14 (API 34)
• Linux (desktop) • linux • linux-x64 • Fedora Linux 40 (Workstation Edition) 6.8.10-300.fc40.x86_64
• Chrome (web) • chrome • web-javascript • Google Chrome 125.0.6422.112
[✓] Network resources
• All expected network resources are available.
• No issues found!
Activity
DanTup commentedon Jun 5, 2024
I'm not able to reproduce this. I had a theory that maybe it was caused by getters overriding fields or vice-versa, however I've tried many combinations without success.
Are you able to provide some code that reproduces the issue? In the screenshot, it looks like
_$OfferingImplis the class showing the duplicates, so taking a copy of that class any superclasses (and even stripping it back to only the definitions ofmonthlythroughout the hierarchy) might trigger the issue.Thanks!
DanTup commentedon Jun 5, 2024
I found the RevenueCat example project but it doesn't seem to use Freezed, so I suspect that won't repro it. I've tried stepping through a few of freezed's tests and examining some of those objects, but don't see the duplication. It may be hard to track down without some more info about the hierarchy in your example.
A log file may also be useful if a repro can't be provided.
obayit commentedon Jun 10, 2024
Same issue?
DanTup commentedon Jun 10, 2024
@obayit seems like it - do you have any example code that repros this that I could debug with?
obayit commentedon Jun 10, 2024
@DanTup Yeah, this repo here.
make a breakpoint at line 149 in main.dart
Edit: add picture:
DanTup commentedon Jun 10, 2024
@obayit thank you, taking a look!
DanTup commentedon Jun 10, 2024
Some logs for my reference. It does look like it might be because of a field and a getter, so perhaps my testing when I noted this above didn't cover all cases. I'll try to extract a smaller repro.
DanTup commentedon Jun 10, 2024
Looks like the issue is when a field overrides a getter (I tried the other way around). Here's a smaller repro:
Will work on a fix. Thanks for the repro! :)
lukehutch commentedon Jun 11, 2024
Sorry I dropped the ball on responding quickly on this, but thanks @obayit for stepping up!
I agree that this is almost certainly an override problem. I don't know if it's about a field overriding a getter in every case, but I can say that at least of what I observed, the value was the same in both cases when there was duplication.
DanTup commentedon Jun 11, 2024
It's not actually guaranteed they were always the same - if you override a field with a getter that returns a different value, you would have seen both the field and the getter:
However I feel that showing the field is a bit pointless (because any access to
a.bwould be the getter forband never the field) so rather than trying to distinguish these, my fix just hides the field when there's a getter.Working on a fix at https://dart-review.googlesource.com/c/sdk/+/370640.
[dds/dap] Prevent duplicate values showing in variables views when a …
DanTup commentedon Jun 11, 2024
This is fixed by dart-lang/sdk@b8cb98d in the Dart SDK. It'll need a DDS release and to roll into Flutter before it shows up there (and then ultimately, stable releases of each SDK).
I'll keep this issue open until it's rolled into Flutter as a reminder that that hasn't happened yet.
stan-at-work commentedon Jun 20, 2024
DanTup commentedon Jun 25, 2024
The fix for this has now rolled into Flutter's
masterchannel. Using the repro project from above there are now no duplicates:lukehutch commentedon Jun 25, 2024
@DanTup thanks!