Repository navigation
Stepping into Dart SDK sources in Flutter results in sources downloaded from the VM instead of used from disk #5164
Description
Some integration tests are failing because when we step into SDK sources, we don't get back a path for the stack frames:
This happens with current master (21d996929bb96facd791d650d1ad35e6024d44ae) but only for flutter-tester ("args": [ "-d", "flutter-tester" ]). Using the Windows device things are fine:
This is possibly a Flutter issue, but needs some more investigation to see what the difference in traffic is over the VM Service.
Activity
DanTup commentedon Jul 2, 2024
This seems to be related to missing sources from the VM. I've opened flutter/flutter#151167.
DanTup commentedon Jul 2, 2024
It turns out that the issue above might not be the main issue. The reason we're trying to get sources from the VM is that we failed to map onto disk. The reason for that is that the Dart SDK URIs changed in flutter-team-archive/engine#51917
Previously we had
org-dartlang-sdk:///third_party/dart/sdkbut now we haveorg-dartlang-sdk:///flutter/third_party/dart/sdk/lib/core/print.dart, so we're not mapping these URIs correctly.We should figure out why this broke no tests (in the Flutter repo for the debug adapter) and update the mapping there.
[flutter_tools] Update the mapping for the Dart SDK internal URI
DanTup commentedon Jul 2, 2024
Main fix is at flutter/flutter#151170.
[flutter_tools] Update the mapping for the Dart SDK internal URI (#15…
[flutter_tools] Update the mapping for the Dart SDK internal URI (flu…
DanTup commentedon Jul 22, 2024
This may need cherry-picking into the next beta.
[-]Unable to step into SDK sources when running on flutter-tester device[/-][+]Stepping into Dart SDK sources in Flutter results in sources downloaded from the VM instead of used from disk[/+]DanTup commentedon Jul 27, 2024
New Flutter beta has branched and included this fix, no cherry-pick is required.