Repository navigation
Using ${name} in a folder of a log name results in "${name}" folders being created #5184
Description
If I set my logs as below, I see a folder called "${name}" created.
This is because we trigger creation of the folder before the debug session name is inserted.
{
"dart.dapLogFile": "C:\\logs\\${workspaceName}\\dapLogFile.txt",
"dart.analyzerLogFile": "C:\\logs\\${workspaceName}\\analyzerLogFile.txt",
"dart.dartTestLogFile": "C:\\logs\\${workspaceName}\\${name}\\dartTestLogFile.txt",
"dart.extensionLogFile": "C:\\logs\\${workspaceName}\\extensionLogFile.txt",
"dart.devToolsLogFile": "C:\\logs\\${workspaceName}\\devToolsLogFile.txt",
"dart.vmServiceLogFile": "C:\\logs\\${workspaceName}\\${name}\\vmServiceLogFile.txt",
"dart.webDaemonLogFile": "C:\\logs\\${workspaceName}\\${name}\\webDaemonLogFile.txt",
"dart.flutterRunLogFile": "C:\\logs\\${workspaceName}\\${name}\\flutterRunLogFile.txt",
"dart.flutterTestLogFile": "C:\\logs\\${workspaceName}\\${name}\\flutterTestLogFile.txt",
"dart.flutterDaemonLogFile": "C:\\logs\\${workspaceName}\\flutterDaemonLogFile.txt",
"dart.toolingDaemonLogFile": "C:\\logs\\${workspaceName}\\toolingDaemonLogFile.txt",
"dart.analyzerInstrumentationLogFile": "C:\\logs\\${workspaceName}\\analyzerInstrumentationLogFile.txt",
}It's also not clear that some of these logs are legacy (for ex. flutter test) because those things are now wrapped up inside DAP and not executed directly by the extension. Those settings should be moved to the archived section.
(reported by @FMorschel on Discord)
Activity
DanTup commentedon Jul 16, 2024
Actually, since we decide which DAP to spawn, we can probably create a logger at that point, and support the original log file kinds. This can be convenient because you can have different log files without needing to know what the session name was for app vs test runs etc.
DanTup commentedon Jul 16, 2024
I've filed some additional issues for some of these related issues:
${name}#5187[-]Using `${name}` in a _folder_ of a log name results in "${name}" folders being created[/-][+]Using `${name}` in a folder of a log name results in `"${name}"` folders being created[/+]