Skip to content

"Performing refactor..." progress status for "Move class to file" #5235

Closed
Closed
"Performing refactor..." progress status for "Move class to file"#5235
Labels
in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.100.0

Description

@FMorschel
FMorschel
opened on Aug 27, 2024

Is your feature request related to a problem? Please describe.
When using the "Move class to file" refactor I see no indication that it is running even when it takes some seconds to finish (probably figuring out dependencies for imports and such).

Describe the solution you'd like
I'd like a toast to show the user something is happening and if something went wrong.

Additional context
See #5218.

Activity

  1. FMorschel
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Aug 27, 2024
  2. DanTup
    added this to the v3.98.0 milestone on Aug 28, 2024
  3. DanTup
    added
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    on Aug 28, 2024
  4. DanTup
    added a commit that references this issue on Sep 26, 2024

    WIP - add progress reporting for move-to-file

    fd52e6f

  5. DanTup commented on Sep 26, 2024

    @DanTup
    DanTup
    on Sep 26, 2024
    Member

    WIP at https://github.com/DanTup/sdk/tree/move-to-file-status... I added progress reporting and can see it in the analyzer logs, but no progress shown on screen. Not sure if it doesn't show a toast (only a spinner), but there's also no spinner. Not sure if having multiple at the same time (there is analyzing statuses too) is causing issues. Needs some debugging.

  6. DanTup
    modified the milestones: v3.98.0, v3.100.0 on Sep 30, 2024

  7. FMorschel commented on Oct 7, 2024

    @FMorschel
    FMorschel
    on Oct 7, 2024
    ContributorAuthor

    Do you believe that this issue is related to the experimental refactor not showing progress as well (coming from dart-lang/sdk#56855)?

  8. DanTup commented on Oct 9, 2024

    @DanTup
    DanTup
    on Oct 9, 2024
    Member

    Yeah, probably. For reasons I don't yet understand, it seems like the progress notifications just aren't showing.

  9. DanTup commented on Oct 9, 2024

    @DanTup
    DanTup
    on Oct 9, 2024
    Member

    Turns out, they do show. But as status bar notifications:

    image

    I've opened microsoft/vscode-languageserver-node#1567 about supporting toast notifications, and I will add support for the status bar notification for these new refactors in the meantime.

  10. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Oct 9, 2024
  11. copybara-service
    added a commit that references this issue on Oct 9, 2024

    [analysis_server] Ensure progress notifications are sent for new inte…

    7088dc4

  12. DanTup commented on Oct 10, 2024

    @DanTup
    DanTup
    on Oct 10, 2024
    Member

    Missing progress updates is implemented via dart-lang/sdk@7088dc4.

    The notifications aren't toast notifications, but it's currently the best I think we can do. Depending on the response to microsoft/vscode-languageserver-node#1567 I will look at using toasts so they're more prominent later.

  13. DanTup
    closed this as completedon Oct 10, 2024
  14. DanTup
    changed the title [-]"Performing refactor..." toast for "Move class to file"[/-] [+]"Performing refactor..." progress status for "Move class to file"[/+] on Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions