Renaming files triggers uri_does_not_exist #5269

Activity

1. FMorschel

   added

   is bug

   on Sep 16, 2024
2. DanTup commented on Sep 16, 2024

   

   DanTup

   on Sep 16, 2024

   Member

   More actions

   Thanks, I've been through the log and filtered it to just the important events and something does look wrong here.

   repro_instrum_filtered.txt

   The operation is done, undone, and redone in the log. The second time everything looks good, but the first time there is a stale uri_does_not_exist that should've become an unused_import.

   The only obvious difference is that in the broken case, the file was opened by VS Code prior to the watch event being processed. I don't know if this is the trigger, but it is something to try and reproduce in a test.

   # VS Code opens c.dart
   13:09:24.286,Req,{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"file:///C%3A/Users/felip_0vh5fa6/Documents/Projects/dart/temp/bin/c.dart","languageId":"dart","version":1,"text":""}},"clientRequestTime":1726488564278}
   
   # The rename happens on disk
   13:09:24.293,Watch,<unknown>,C:\Users\felip_0vh5fa6\Documents\Projects\dart\temp\bin\c.dart,add
   13:09:24.293,Watch,<unknown>,C:\Users\felip_0vh5fa6\Documents\Projects\dart\temp\bin\a.dart,remove
   
   ####### We resend uri_does_not_exist even though the file does exist.. It's possible we haven't processed it yet, but it appears that we never correct the issue.
   13:09:24.426,Res,{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"uri_does_not_exist","codeDescription":{"href":"https://dart.dev/diagnostics/uri_does_not_exist"},"message":"Target of URI doesn't exist: 'c.dart'.\nTry creating the file referenced by the URI, or try using a URI for a file that does exist.","range":{"end":{"character":15,"line":2},"start":{"character":7,"line":2}},"severity":1,"source":"dart"},{"code":"unused_import","codeDescription":{"href":"https://dart.dev/diagnostics/unused_import"},"message":"Unused import: 'b.dart'.\nTry removing the import directive.","range":{"end":{"character":15,"line":3},"start":{"character":7,"line":3}},"severity":2,"source":"dart"}],"uri":"file:///C:/Users/felip_0vh5fa6/Documents/Projects/dart/temp/bin/temp.dart"}}
   
3. DanTup

   added this to the v3.98.0 milestone on Sep 16, 2024
4. DanTup

   added

   in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Sep 16, 2024
5. DanTup

   modified the milestones: v3.98.0, v3.100.0 on Sep 26, 2024
6. DanTup commented on Oct 28, 2024

   

   DanTup

   on Oct 28, 2024

   Last edited by DanTup

   Member

   More actions

   I managed to repro this today by undoing and redoing using exactly the steps above. Not sure if important, but I didn't save main.dart after adding the initial import.

   Edit: And at one point, I repro'd without the undo/redo.

   instrum copy.txt
7. FMorschel commented on Oct 28, 2024

   

   FMorschel

   on Oct 28, 2024

   ContributorAuthor

   More actions

   Not sure if important, but I didn't save main.dart after adding the initial import.

   I do have auto-save set to 1 second so I don't think that would make a difference, but good to track.
8. DanTup commented on Oct 28, 2024

   

   DanTup

   on Oct 28, 2024

   Member

   More actions

   Yeah, I don't think it matters. I think I've repro'd in a test, and I think it might be the same issue as dart-lang/sdk#55318 and so an easier way to reproduce is:

   • add "import 'foo.dart';" to a file
   • now create "foo.dart"

   The uri_does_not_exist error doesn't go away. I think it may be because creating the file foo.dart does not invalidate any files that had an unresolved import for foo.dart.

   🚀React with 🚀1Reacted by Felipe Morschel
9. copybara-service

   added a commit that references this issue on Oct 28, 2024

   [analysis_server] Don't treat non-existent files the same as empty fi…

   ...

   12d9554
10. DanTup commented on Oct 28, 2024

    

    DanTup

    on Oct 28, 2024

    Member

    More actions

    Fixed by dart-lang/sdk@12d9554. The change is in the analysis server so ships with a future Dart/Flutter SDK.
11. DanTup

    closed this as completedon Oct 28, 2024
12. DanTup

    added

    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become availableSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    on Oct 28, 2024