Repository navigation
Embedded DevTools pages have larger than expected text #5276
Description
Describe the bug
Widget Inspector incompatible size in vscode.
To Reproduce
Steps to reproduce the behavior:
- Go to run 'main.dart'
- Click on 'Widget Inspector'
Expected behavior
I wish Widget Inspector can properly support the size.
Screenshots
Please complete the following information:
You can run the Dart: Collect Diagnostic Information command from the VS Code command palette (F1) to easily capture this information or provide it manually.
- Operating System and version:
- VS Code version:on windows / "Windows 10 Enterprise" 10.0 (Build 19045)
- Dart extension version: 3.96.0
- Dart/Flutter SDK version: 3.97.20240902 (activated)
- Target device (if the issue relates to Flutter debugging):(Windows (windows-x64/windows))
Activity
DanTup commentedon Sep 18, 2024
@kenzieschmoll we pass the editor font size to DevTools so that the general text matches the text size in the editor (because we assume this is set to something reasonable for the user). This seems to be working, because the tree text matches the editor text as can be seen clearer in this side-by-side image:
However, the titles are much larger. I don't think we want to scale everything down (because the general text would be too small), so I wonder if we should change titles? (either generally, or tie it to the theme so for VS Code we could make the titles better match how they'd appear there - which is generally the same size but all caps).
(I'll also note that the text in the VS Code Outline on the bottom left seems a bit smaller, but unfortunately we have no way of getting at that text size from the extension - it doesn't have a setting like the editor text).
DanTup commentedon Sep 30, 2024
@Chuan1937 I see you closed this, but I think this is still a valid issue - the titles look much too large and don't fit in with VS Code. It would be nice to explore if we can improve this.
[-]Widget Inspector incompatible size in vscode[/-][+]Embedded DevTools pages have larger than expected text[/+]DanTup commentedon Feb 17, 2025
Fixed as part of #5406