Repository navigation
Remove allowlist for recommended extensions #5321
Description
Hi, given the Dart VS Code extension supports suggesting VS Code extensions based on the installed packages, it would be great to either remove the allow list or have a clear process of how a new extension can be added there.
For DCM, we have a presets package https://github.com/CQLabs/dart-code-metrics-presets that clearly indicates that the project uses DCM and therefore the user would benefit from such a notification if the DCM extension is not installed.
Also, if the required configuration is not documented anywhere, it would be great to have documentation for it as well.
Activity
DanTup commentedon Oct 27, 2024
My feeling is that we should just remove the allowlist at this point, it's had reasonable testing (serverpod is using it in production) and the possibility of abuse seems low (cc @kenzieschmoll @jwren - in case you have different opinions).
@kenzieschmoll is there any existing documentation about this (the file format for
extensions/vscode/config.yaml)? Since DevTools owns the format it's probably better documented somewhere there, but maybe it would also be useful to link to from the Dart-Code website and/or the description about the setting.@incendial if you want to test this locally to ensure it works in the meantime, you can add the following to your VS Code user settings:
(VS Code may say it's not a valid setting, but that's just because it's hidden, as it's only there as a way of testing while there was an allowlist)
jwren commentedon Oct 28, 2024
Sounds good to me, include this issue in the comments with the change for documentation prosperity. We can always change our mind in the future with other information.
kenzieschmoll commentedon Oct 29, 2024
Removing the allowlist sgtm. I filed an issue to create docs on contributing to tooling on flutter.dev: flutter/website#11339
[-]Update/remove allowed list for recommended extensions[/-][+]Remove allowlist for recommended extensions[/+]Remove extension promotion allowlist