Implement refactor: Inline method #547

Activity

1. DanTup

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   in editorRelates to code editing or language featuresRelates to code editing or language features

   on Feb 8, 2018
2. DanTup

   added this to the On Deck milestone on Feb 8, 2018
3. DanTup

   added

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   on Feb 12, 2018
4. DanTup commented on Feb 12, 2018

   

   DanTup

   on Feb 12, 2018

   MemberAuthor

   More actions

   I don't think putting refactors on the lightbulb is a good idea, as they show up so frequently that there will just be bulbs everywhere always. I suggest these go on the context menu:

   microsoft/vscode#9827
5. DanTup

   removed

   blocked on vs code / lsp / dapRequires a change in VS Code to progressRequires a change in VS Code to progress

   on Feb 21, 2018
6. DanTup commented on Dec 19, 2018

   

   DanTup

   on Dec 19, 2018

   MemberAuthor

   More actions

   Requires dart-lang/sdk#35448.
7. DanTup

   added

   blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

   on Dec 19, 2018
8. DanTup

   modified the milestones: On Deck, Backlog on Mar 19, 2019
9. DanTup

   modified the milestones: Backlog, On Deck on Nov 18, 2020
10. DanTup

    added

    in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

    and removed

    blocked on dart / flutterRequires a change in Dart or Flutter to progressRequires a change in Dart or Flutter to progress

    on Nov 18, 2020
11. DanTup

    modified the milestones: On Deck, v3.22.0 on Apr 27, 2021
12. svarlet commented on Apr 28, 2021

    

    svarlet

    on Apr 28, 2021

    More actions

    Hi @DanTup !
    I just noticed the completion of the similar issue about inlining variables. What's the status on this issue? Inlining methods is an even more useful refactoring 😍
13. DanTup commented on Apr 28, 2021

    

    DanTup

    on Apr 28, 2021

    MemberAuthor

    More actions

    @svarlet hoping to look at this shortly too :-)

    👍React with 👍1Reacted by Sébastien Varlet
14. DanTup commented on Apr 29, 2021

    

    DanTup

    on Apr 29, 2021

    MemberAuthor

    More actions

    I've got a change open for this at https://dart-review.googlesource.com/c/sdk/+/197380/.
15. dart-bot

    added a commit that references this issue on Apr 29, 2021

    [analyzer] Support "Inline Method" refactor in LSP

    ...

    a89fccb
16. DanTup commented on Apr 29, 2021

    

    DanTup

    on Apr 29, 2021

    MemberAuthor

    More actions

    Fixed in dart-lang/sdk@a89fccb.
17. DanTup

    closed this as completedon Apr 29, 2021