Repository navigation
Code completion triggers in doc comments #5507
Description
Not sure what's happened here, but when I type full-stops in doc comments, it now triggers code completion (which also contains results) where I don't think it used to.
{{ message }}
Activity
FMorschel commentedon May 7, 2025
Actually, I can trigger auto-completion anywhere, no need for
.or anything. The only requirement is having one[]somewhere. It can even be empty.FMorschel commentedon May 8, 2025
I'd like to take a look at this if you don't mind.
FMorschel commentedon May 8, 2025
I found the problem already, I'll wrap this up and post the CL here.
DanTup commentedon May 8, 2025
@FMorschel great, thanks! I hadn't even had chance to figure out if this was in Dart-Code or the server.. sounds like you're way ahead :-)
FMorschel commentedon May 8, 2025
This is the original CL that caused the regression https://dart-review.googlesource.com/c/sdk/+/411380. The correct resolution for that problem was worked on at https://dart-review.googlesource.com/c/sdk/+/419422. It was easy for me because I was the one who introduced these tests, and both CLs were mine. I've been working on comment references and completions for a bit.
This is the new CL that fixes this issue: https://dart-review.googlesource.com/c/sdk/+/427460
DanTup commentedon May 12, 2025
@FMorschel thanks!
[DAS] Fixes comment references completion outside braces
FMorschel commentedon May 14, 2025
The above CL has landed. This can be closed!
DanTup commentedon May 14, 2025
Thank you!