Repository navigation
Writing ; inside an enhanced enum without the constructor makes it get removed #5602
Description
Describe the bug
When writing ; inside enhanced enum before it contains a constructor, it gets removed.
To Reproduce
Steps to reproduce the behavior:
- In a dart file, write
enum Enhanced { e } - Add
;aftereand see the code will stay the same
Expected behavior
I expect the ; to stay there so I can write the constructor.
Please complete the following information:
Workspace Environment
Dart Code extension: 3.115.20250715
Flutter extension: 3.115.20250701 (activated)
App: Visual Studio Code
App Host: desktop
Version: win 1.102.2
Workspace type: Dart (LSP)
Workspace name: bug
Dart (3.10.0-edge.7e05022286da202d366091d3efa446e6fbf685ab): C:\Users\felip_0vh5fa6\dart
Flutter (3.32.7): C:\Users\felip_0vh5fa6\.puro\envs\stable\flutter (No device)
Output from 'dart info'
C:\Users\felip_0vh5fa6\dart\bin\dart.exe info
If providing this information as part of reporting a bug, please review the information
below to ensure it only contains things you're comfortable posting publicly.
General info
- Dart 3.10.0-edge.7e05022286da202d366091d3efa446e6fbf685ab (main) (Fri Jul 18 17:46:04 2025 -0700) on "windows_x64"
- on windows / "Windows 11 Pro" 10.0 (Build 26100)
- locale is pt-BR
Project info
- sdk constraint: '^3.9.0-edge.bddcddfe6b0914c7f234cd4400e1e70e8a72d374'
- dependencies: bloc, due_date, meta
- dev_dependencies: lints, test, test_reflective_loader, very_good_analysis
Process info
| Memory | CPU | Elapsed time | Command line |
|---|---|---|---|
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe | |
| 0 MB | -- | dart.exe |
Activity
DanTup commentedon Jul 24, 2025
The reason this happens is the
dart.formatOnTypesetting. This setting instructs VS Code to format your code as you are typing, and;is a trigger character for that (because usually, completing a statement would be a logical time for format-on-type to fire).However, this doesn't work so well if the formatter might remove semicolons.
Some possible options:
;as a format-on-type triggerThis would reduce the usefulness of format-on-type, but it would still be on
}We do have the character that triggered the format, and a
Position, however the spec (about theposition) says:@bwilkerson any thoughts or other ideas?
@munificent any thoughts/opinions on something like (3)?
bwilkerson commentedon Jul 24, 2025
While the semicolon is optional when there's nothing else following it, it isn't clear to me that the formatter should treat it like whitespace. I can see the argument for doing so because in some ways it feels like an optional trailing comma, but it seems different to me, maybe because the trailing semicolon has never been used to control formatting.
I'm not thrilled with option (3) because that means that server would need to have logic to determine when to pass in the flag and when not to, and that seems error prone and/or confusing for the user. Or else we just always disable it within the IDE, but then why make it an option?
DanTup commentedon Jul 24, 2025
I guess not doing that is another option (and one for Bob's opinion) - I added as (4).
My idea was to always pass it when responding to
format-on-type(this is a different LSP request to the general format, or format-range). Eg., if the formatter had two modes - one that only touches whitespace, and one that does also does other "cleanup", we could ensure that when typing, we only ever use the first, but on-save or explicit formats we did the second.FMorschel commentedon Nov 14, 2025
As linked above, for anyone who finds this and is interested in the discussions around this, we also have:
;in enums interacts poorly with VSCode dart-lang/dart_style#1782[analysis_server] Exclude the enum body semicolon from format-on-type
DanTup commentedon Dec 4, 2025
Fixed by dart-lang/sdk@ff5706e, ships in the SDK.
munificent commentedon Jan 12, 2026
Thanks for the fix, Danny!