Repository navigation
Override completions do not automatically set selection #5652
Description
Since today's release, this test is failing:
1) completion_item_provider
inserts full text for overrides:
AssertionError [ERR_ASSERTION]: actual: 8:52-8:52 () vs expected: 8:25-8:51 (throw UnimplementedError())
false !== true
+ expected - actual
-false
+true
at ensureTestSelection (src/test/helpers.ts:993:9)
at ensureTestContentWithSelection (src/test/helpers.ts:1004:2)
at Context.<anonymous> (src/test/dart/providers/completion_item_provider.test.ts:136:3)
It appears that after completing this code, the selection is just at the end of the throw UnimplementedError() instead of selecting it:
Activity
Fix a test, skip a test
DanTup commentedon Sep 2, 2025
The issue was in the server, fix open at https://dart-review.googlesource.com/c/sdk/+/448180
[-]Fix/unskip failing test[/-][+]Override completions do not automatically set selection[/+][analysis_server] Fix missing selection in override completions
DanTup commentedon Sep 15, 2025
Fixed by dart-lang/sdk@6ac7afd
DanTup commentedon Sep 15, 2025
We need to update the skipped test.