Skip to content

Dart: Apply Fix All in Workspace running toast #5773

Closed
Closed
Dart: Apply Fix All in Workspace running toast#5773
Labels
in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.124.0

Description

@FMorschel
FMorschel
opened on Oct 29, 2025

Is your feature request related to a problem? Please describe.
I ran Dart: Apply Fix All in Workspace with a list of 4887 diagnostic to fix, and although it ran fine, I could not tell that it was running.

Describe the solution you'd like
I'd like to see a toast to indicate that some processing is happening.

Describe alternatives you've considered
Doing it from the terminal allows me to see that the process is running since I can't write more things.

Activity

  1. FMorschel
    added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    on Oct 29, 2025

  2. DanTup commented on Nov 6, 2025

    @DanTup
    DanTup
    on Nov 6, 2025
    Member

    Recording this here for future me... Seems like we have code that should show progress, added in dart-lang/sdk@1ea4b88 - Needs some debugging!

  3. DanTup commented on Nov 6, 2025

    @DanTup
    DanTup
    on Nov 6, 2025
    Member

    Nope, that added plumbing for it, but each command needs to opt-in to showing the progress (to avoid spam for the very quick commands).

    Fix is at https://dart-review.googlesource.com/c/sdk/+/460044

    Although I'll note that it doesn't show a toast, it shows the more subtle progress notification:

    Image

    This is because the LSP client doesn't currently support the bigger toast notifications (or middleware to let us do it) - see microsoft/vscode-languageserver-node#1567

  4. DanTup
    added this to the v3.124.0 milestone on Nov 6, 2025
  5. DanTup
    added
    in editorRelates to code editing or language features
    in lsp/analysis serverSomething to be fixed in the Dart analysis server
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Nov 6, 2025
  6. copybara-service
    added a commit that references this issue on Nov 7, 2025

    [analysis_server] Add progress reporting to "Fix all in Workspace" co…

    2fea3c0

  7. DanTup commented on Nov 10, 2025

    @DanTup
    DanTup
    on Nov 10, 2025
    Member

    Fixed by dart-lang/sdk@2fea3c0, ships in the SDK

  8. DanTup
    closed this as completedon Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresin lsp/analysis serverSomething to be fixed in the Dart analysis serveris enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions