Deleting a test results in the next test marker moving to the wrong line #5831

Activity

1. DanTup

   added

   is bug

   on Dec 3, 2025
2. DanTup

   added this to the v3.126.0 milestone on Dec 3, 2025
3. DanTup

   added

   in testingRelates to test execution of Dart/Flutter tests for end usersRelates to test execution of Dart/Flutter tests for end users

   on Dec 3, 2025
4. FMorschel commented on Dec 4, 2025

   

   FMorschel

   on Dec 4, 2025

   Last edited by FMorschel

   Contributor

   More actions

   Typo (title): marker*

   👍React with 👍1Reacted by Danny Tuppeny
5. DanTup

   changed the title [-]Deleting a test results in the next test market moving to the wrong line[/-] [+]Deleting a test results in the next test marker moving to the wrong line[/+] on Dec 4, 2025
6. FMorschel commented on Dec 4, 2025

   

   FMorschel

   on Dec 4, 2025

   Last edited by FMorschel

   Contributor

   More actions

   Run the following test file and run Dart: Sort Members. See a similar behaviour. Is this the exact same?

   import 'package:test/test.dart';
   import 'package:test_reflective_loader/test_reflective_loader.dart';
   
   void main() {
     defineReflectiveSuite(() {
       defineReflectiveTests(ATEst);
     });
   }
   
   @reflectiveTest
   class ATEst {
     void test_example() {
       // Example test
       expect(1 + 1, 2);
     }
   
     void test_anotherExample() {
       // Another example test
       // this
       // one
       // is
       // longer
       expect('hello'.toUpperCase(), 'HELLO');
     }
   
     void test_yetAnotherExample() {
       // Yet another example test
       expect([1, 2, 3].length, 3);
     }
   }

   Note that it doesn't happen if all tests are the same line length.
7. DanTup

   added 2 commits that reference this issue on Dec 4, 2025

   Fix test tracking when ranges are deleted

   ...

   452110c

   Fix test tracking when ranges are deleted

   ...

   e9d2895
8. DanTup commented on Dec 4, 2025

   

   DanTup

   on Dec 4, 2025

   MemberAuthor

   More actions

   With my fix, I end up with this:

   

   The top two get swapped around, and their positions removed.

   The bug was that when a tracked range (which is a start and end position) was deleted, we first deleted the start position (internally, range tracker is just two position trackers), which caused the first range tracker to dispose itself. This reduced the number of position trackers, but it was done in a callback during the processing, so the code looping over the position trackers skipped one (because the collection was modified).

   This resulted in only the end position of the second range being changed (resulting in a range where the start was before the end!) which caused weird things to happen.
9. DanTup

   added a commit that references this issue on Dec 4, 2025

   Fix test tracking when ranges are deleted

   ...

   fddc310
10. DanTup

    closed this as completedin #5834on Dec 4, 2025