You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
class-wide setUp/tearDown methods (using package:test_reflective_loader) jump to the defineReflectiveSuite call instead of their actual locations #5950
Perhaps we should be passing locations along to those so it goes to the right place (eg. the setUpClass function), but also maybe we shouldn't call setUpAll at all if there isn't a setUpClass.
changed the title [-]setUpAll/tearDownAll tests show up on the `defineReflectiveSuite` call in Dart SDK[/-][+]class-wide setUp/tearDown methods (using `package:test_reflective_loader`) jump to the `defineReflectiveSuite` call instead of their actual locations[/+]on Mar 9, 2026
Activity
DanTup commentedon Mar 2, 2026
Could it be related to dart-lang/tools#2164?
Perhaps we should be passing locations along to those so it goes to the right place (eg. the
setUpClassfunction), but also maybe we shouldn't callsetUpAllat all if there isn't asetUpClass.Peter080202 commentedon Mar 9, 2026
@DanTup will tackle this one soon
DanTup commentedon Mar 9, 2026
@Peter080202 I'm actually looking at this one right now (it'll be a change in
package:test_reflective_loader).[-]setUpAll/tearDownAll tests show up on the `defineReflectiveSuite` call in Dart SDK[/-][+]class-wide setUp/tearDown methods (using `package:test_reflective_loader`) jump to the `defineReflectiveSuite` call instead of their actual locations[/+]Peter080202 commentedon Mar 9, 2026
Ok sure
[test_reflective_loader] Don't add setUp/tearDown if not defined, and…
[test_reflective_loader] Don't add setUp/tearDown if not defined, and…
DanTup commentedon Mar 9, 2026
I've a PR open at dart-lang/tools#2341
DanTup commentedon Jul 31, 2026
Fixed in test_reflective_loader (dart-lang/tools#2341).