Skip to content

Remove capabilities flags related to unsupported SDKs, and prune dead code - #5976

Merged
DanTup merged 1 commit into
masterfrom
prune-capabilities-and-remove-dead-code
Mar 11, 2026
Merged

DanTup merged 1 commit into
masterfrom
prune-capabilities-and-remove-dead-code

Conversation

@DanTup

@DanTup DanTup commented Mar 11, 2026

Copy link
Copy Markdown
Member

Fixes #5974

devin-ai-integration[bot]

This comment was marked as resolved.

@codecov

codecov Bot commented Mar 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (ebd5410) to head (41166f3).

Files with missing lines Patch % Lines
src/shared/capabilities/dart.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5976      +/-   ##
==========================================
+ Coverage   67.51%   67.52%   +0.01%     
==========================================
  Files         169      169              
  Lines       12974    12963      -11     
  Branches     2566     2565       -1     
==========================================
- Hits         8759     8753       -6     
+ Misses       3756     3752       -4     
+ Partials      459      458       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanTup
DanTup force-pushed the prune-capabilities-and-remove-dead-code branch from 78efb52 to 41166f3 Compare March 11, 2026 13:55
@DanTup

DanTup commented Mar 11, 2026

Copy link
Copy Markdown
Member Author

@codex review

/gemini review

@DanTup
DanTup requested a review from Copilot March 11, 2026 14:23
@gemini-code-assist

Copy link
Copy Markdown

Thank you for invoking /gemini review. This pull request streamlines the codebase by removing obsolete capability flags and associated dead code, particularly those related to older Dart Debug Adapter Protocol (DAP) distinctions and certain web capabilities. Codecov Report Issue: The Codecov report highlights a missing coverage line in src/shared/capabilities/dart.ts. This indicates a potential gap in test coverage, possibly due to a test no longer covering a modified line, or an attempt to access a capability that has been removed or refactored. Please investigate this to ensure all relevant code paths are adequately tested and that no regressions are introduced by the removal of these flags. Severity: low

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@DanTup
DanTup force-pushed the prune-capabilities-and-remove-dead-code branch from 41166f3 to 6767092 Compare March 11, 2026 14:36
@DanTup
DanTup merged commit d1d61d7 into master Mar 11, 2026
20 of 22 checks passed
@DanTup
DanTup deleted the prune-capabilities-and-remove-dead-code branch March 11, 2026 14:36
@DanTup DanTup added this to the v3.132.0 milestone Mar 11, 2026
@DanTup DanTup added the is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. label Mar 11, 2026
@DanTup
DanTup removed the request for review from Copilot March 23, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove capabilities flags and related code for old SDKs

1 participant