Skip to content

Reduce number of tests that are now covered by the analysis server/SDK DAPs #6009

Closed

Description

@DanTup

There are a lot of tests that verify very specific details that used to exist here in the legacy-protocol -> VS Code mappings, that are now just part of LSP.

For example, there are a large number of completion tests:

https://github.com/Dart-Code/Dart-Code/blob/master/src/test/dart/providers/completion_item_provider.test.ts

Most of these are verifying things where the logic now exists in (and is tested in) the LSP server. Having all of these tests is somewhat redundant and makes the test runs slower.

We should instead just keep a few basic tests that ensure the general interaction with completion is working, and not all of the specifics about how the server maps things (these kinds of tests just fail if we do make changes to how we map things in the server).

The same is likely true for a lot of language features, and probably many debug features as a result of DAP moving to the SDKs too.

Activity

  1. added this to the v3.134.0 milestone on Mar 29, 2026
  2. added
    is testingRelates to the testing (either manual or automated) of Dart Code
    on Mar 29, 2026
  3. changed the title [-]Reduce number of tests that are now covered by the analysis server[/-] [+]Reduce number of tests that are now covered by the analysis server/SDK DAPs[/+] on Mar 29, 2026
  4. modified the milestones: v3.134.0, v3.136.0 on Apr 29, 2026
  5. DanTup commented on May 14, 2026

    @DanTup
    MemberAuthor

    I've merged some of the Flutter debugger tests together to speed things up a bit, but in general each bot is < 10mins which I think is acceptable (and there is value in some of these tests because it ensures the interaction with VS Code/DAPs is working).

    So, I'm leaving this as-is for now. If tests break due to changes in server/DAP, I will consider whether we should fix or just remove them on a case-by-case basis (reducing the maintenance is a more worthwhile goal than speeding up the bots now IMO).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    is testingRelates to the testing (either manual or automated) of Dart Code

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions