Skip to content

Don't show full package list in "Add Dependency" completion immediately after separator - #6029

Merged
DanTup merged 2 commits into
masterfrom
pub-no-completions-after-separator
Apr 14, 2026
Merged

DanTup merged 2 commits into
masterfrom
pub-no-completions-after-separator

Conversation

@DanTup

@DanTup DanTup commented Apr 14, 2026

Copy link
Copy Markdown
Member

Require at least one character to be typed.

Fixes #5952

@DanTup DanTup added this to the v3.134.0 milestone Apr 14, 2026
@DanTup DanTup added is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix. in commands Relates to commands (usually invoked from the command Palette) labels Apr 14, 2026
@DanTup
DanTup requested a review from Copilot April 14, 2026 13:19

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@codecov

codecov Bot commented Apr 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.36%. Comparing base (f4ac550) to head (c9f8487).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6029      +/-   ##
==========================================
+ Coverage   68.23%   68.36%   +0.12%     
==========================================
  Files         170      170              
  Lines       12925    12927       +2     
  Branches     2574     2575       +1     
==========================================
+ Hits         8820     8837      +17     
+ Misses       3642     3631      -11     
+ Partials      463      459       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AddDependencyCommand to improve the package search experience. It ensures that the full package list is not displayed when a user has entered a separator (like a space or comma) but has not yet started typing the next package name, addressing issue #5952. The logic now adds a blank entry in these cases, and the return condition was updated to check for any user input. New tests have been added to verify this behavior, and existing tests were reorganized for better structure. I have no feedback to provide.

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

…ly after separator

Require at least one character to be typed.

Fixes #5952
@DanTup
DanTup force-pushed the pub-no-completions-after-separator branch 2 times, most recently from 3577318 to 7a29179 Compare April 14, 2026 13:32
@DanTup
DanTup force-pushed the pub-no-completions-after-separator branch from 7a29179 to c9f8487 Compare April 14, 2026 13:38
@DanTup
DanTup merged commit 5b7cbaa into master Apr 14, 2026
26 checks passed
@DanTup
DanTup deleted the pub-no-completions-after-separator branch April 14, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in commands Relates to commands (usually invoked from the command Palette) is enhancement An enhancement or improvement that should be listed in release notes but is not a bug fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Dependency selects the first entry with one more package even if you only wrote a whitespace after the last one

2 participants